History

net: usb: cdc_ncm: don't spew notifications

RTL8156 sends notifications about every 32ms. Only display/log notifications when something changes. This issue has been reported by others: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1832472 https://lkml.org/lkml/2020/8/27/1083 ... [785962.779840] usb 1-1: new high-speed USB device number 5 using xhci_hcd [785962.929944] usb 1-1: New USB device found, idVendor=0bda, idProduct=8156, bcdDevice=30.00 [785962.929949] usb 1-1: New USB device strings: Mfr=1, Product=2, SerialNumber=6 [785962.929952] usb 1-1: Product: USB 10/100/1G/2.5G LAN [785962.929954] usb 1-1: Manufacturer: Realtek [785962.929956] usb 1-1: SerialNumber: 000000001 [785962.991755] usbcore: registered new interface driver cdc_ether [785963.017068] cdc_ncm 1-1:2.0: MAC-Address: 00:24:27:88:08:15 [785963.017072] cdc_ncm 1-1:2.0: setting rx_max = 16384 [785963.017169] cdc_ncm 1-1:2.0: setting tx_max = 16384 [785963.017682] cdc_ncm 1-1:2.0 usb0: register 'cdc_ncm' at usb-0000:00:14.0-1, CDC NCM, 00:24:27:88:08:15 [785963.019211] usbcore: registered new interface driver cdc_ncm [785963.023856] usbcore: registered new interface driver cdc_wdm [785963.025461] usbcore: registered new interface driver cdc_mbim [785963.038824] cdc_ncm 1-1:2.0 enx002427880815: renamed from usb0 [785963.089586] cdc_ncm 1-1:2.0 enx002427880815: network connection: disconnected [785963.121673] cdc_ncm 1-1:2.0 enx002427880815: network connection: disconnected [785963.153682] cdc_ncm 1-1:2.0 enx002427880815: network connection: disconnected ... This is about 2KB per second and will overwrite all contents of a 1MB dmesg buffer in under 10 minutes rendering them useless for debugging many kernel problems. This is also an extra 180 MB/day in /var/logs (or 1GB per week) rendering the majority of those logs useless too. When the link is up (expected state), spew amount is >2x higher: ... [786139.600992] cdc_ncm 2-1:2.0 enx002427880815: network connection: connected [786139.632997] cdc_ncm 2-1:2.0 enx002427880815: 2500 mbit/s downlink 2500 mbit/s uplink [786139.665097] cdc_ncm 2-1:2.0 enx002427880815: network connection: connected [786139.697100] cdc_ncm 2-1:2.0 enx002427880815: 2500 mbit/s downlink 2500 mbit/s uplink [786139.729094] cdc_ncm 2-1:2.0 enx002427880815: network connection: connected [786139.761108] cdc_ncm 2-1:2.0 enx002427880815: 2500 mbit/s downlink 2500 mbit/s uplink ... Chrome OS cannot support RTL8156 until this is fixed.

Grant Grundler committed 5 years ago

Commit de658a11 parent 584b7cf2 files · +13 −1Browse files

Unified · Split

2 files
  1. drivers/net/usb/cdc_ncm.c +11 −1
  2. include/linux/usb/usbnet.h +2 −0
drivers/net/usb/cdc_ncm.c+11−1
@@ -1827,6 +1827,15 @@ cdc_ncm_speed_change(struct usbnet *dev, · 1826 unmodified lines
1827 uint32_t rx_speed = le32_to_cpu(data->DLBitRRate);1827 uint32_t rx_speed = le32_to_cpu(data->DLBitRRate);
1828 uint32_t tx_speed = le32_to_cpu(data->ULBitRate);1828 uint32_t tx_speed = le32_to_cpu(data->ULBitRate);
1829 1829
1830 /* if the speed hasn't changed, don't report it.
1831 * RTL8156 shipped before 2021 sends notification about every 32ms.
1832 */
1833 if (dev->rx_speed == rx_speed && dev->tx_speed == tx_speed)
1834 return;
1835
1836 dev->rx_speed = rx_speed;
1837 dev->tx_speed = tx_speed;
1838
1830 /*1839 /*
1831 * Currently the USB-NET API does not support reporting the actual1840 * Currently the USB-NET API does not support reporting the actual
1832 * device speed. Do print it instead.1841 * device speed. Do print it instead.
@@ -1867,7 +1876,8 @@ static void cdc_ncm_status(struct usbnet *dev, struct urb *urb) · 34 unmodified lines
1867 * USB_CDC_NOTIFY_NETWORK_CONNECTION notification shall be1876 * USB_CDC_NOTIFY_NETWORK_CONNECTION notification shall be
1868 * sent by device after USB_CDC_NOTIFY_SPEED_CHANGE.1877 * sent by device after USB_CDC_NOTIFY_SPEED_CHANGE.
1869 */1878 */
1870 usbnet_link_change(dev, !!event->wValue, 0);1879 if (netif_carrier_ok(dev->net) != !!event->wValue)
1880 usbnet_link_change(dev, !!event->wValue, 0);
1871 break;1881 break;
1872 1882
1873 case USB_CDC_NOTIFY_SPEED_CHANGE:1883 case USB_CDC_NOTIFY_SPEED_CHANGE:
include/linux/usb/usbnet.h+2−0
@@ -81,6 +81,8 @@ struct usbnet { · 80 unmodified lines
81# define EVENT_LINK_CHANGE 1181# define EVENT_LINK_CHANGE 11
82# define EVENT_SET_RX_MODE 1282# define EVENT_SET_RX_MODE 12
83# define EVENT_NO_IP_ALIGN 1383# define EVENT_NO_IP_ALIGN 13
84 u32 rx_speed; /* in bps - NOT Mbps */
85 u32 tx_speed; /* in bps - NOT Mbps */
84};86};
85 87
86static inline struct usb_driver *driver_of(struct usb_interface *intf)88static inline struct usb_driver *driver_of(struct usb_interface *intf)