History

genirq: Set IRQCHIP_SKIP_SET_WAKE for no_irq_chip

If no_irq_chip is used for wake up (e.g. gpio-keys with a simple GPIO controller), the following warning is printed on resume from s2ram: WANING: CPU: 0 PID: 1046 at kernel/irq/manage.c:537 irq_set_irq_wake+0x9c/0xf8() Unbalanced IRQ 113 wake disable This happens because no_irq_chip does not implement irq_chip.irq_set_wake(), causing set_irq_wake_real() to return -ENXIO, and irq_set_irq_wake() to reset the wake_depth to zero. Set IRQCHIP_SKIP_SET_WAKE to indicate that irq_chip.irq_set_wake() is not implemented. Cfr. commit 10a50f1ab5f06c9a ("genirq: Set IRQCHIP_SKIP_SET_WAKE flag for dummy_irq_chip").

Geert Uytterhoeven committed 11 years ago

Commit de8d1811 parent e1a96fb1 file · +1 −0Browse files

Unified · Split

kernel/irq/dummychip.c+1−0
@@ -42,6 +42,7 @@ struct irq_chip no_irq_chip = { · 41 unmodified lines
4242 .irq_enable = noop,
4343 .irq_disable = noop,
4444 .irq_ack = ack_bad,
45+ .flags = IRQCHIP_SKIP_SET_WAKE,
4546 };
4647
4748 /*

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t