History

thermal: fix intel PCH thermal driver mismerge

I didn't notice this when merging the thermal code from Zhang, but his merge (commit 5a924a07f882: "Merge branches 'thermal-core' and 'thermal-intel' of .git into next") of the thermal-core and thermal-intel branches was wrong. In thermal-core, commit 17e8351a7739 ("thermal: consistently use int for temperatures") converted the thermal layer to use "int" for temperatures. But in parallel, in the thermal-intel branch commit d0a12625d2ff ("thermal: Add Intel PCH thermal driver") added support for the intel PCH thermal sensor using the old interfaces that used "unsigned long" pointers. This resulted in warnings like this: drivers/thermal/intel_pch_thermal.c:184:14: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types] .get_temp = pch_thermal_get_temp, ^ drivers/thermal/intel_pch_thermal.c:184:14: note: (near initialization for ‘tzd_ops.get_temp’) drivers/thermal/intel_pch_thermal.c:186:19: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types] .get_trip_temp = pch_get_trip_temp, ^ drivers/thermal/intel_pch_thermal.c:186:19: note: (near initialization for ‘tzd_ops.get_trip_temp’) This fixes it.

Linus Torvalds committed 11 years ago

Commit dfb22fc1 parent 01b0c011 file · +4 −7Browse files

Unified · Split

drivers/thermal/intel_pch_thermal.c+4−7
@@ -117,8 +117,7 @@ read_trips: · 116 unmodified lines
117117 return 0;
118118 }
119119
120−static int pch_wpt_get_temp(struct pch_thermal_device *ptd,
121− unsigned long *temp)
120+static int pch_wpt_get_temp(struct pch_thermal_device *ptd, int *temp)
122121 {
123122 u8 wpt_temp;
124123
@@ -132,7 +131,7 @@ static int pch_wpt_get_temp(struct pch_thermal_device *ptd, · 7 unmodified lines
132131
133132 struct pch_dev_ops {
134133 int (*hw_init)(struct pch_thermal_device *ptd, int *nr_trips);
135− int (*get_temp)(struct pch_thermal_device *ptd, unsigned long *temp);
134+ int (*get_temp)(struct pch_thermal_device *ptd, int *temp);
136135 };
137136
138137
@@ -142,8 +141,7 @@ static struct pch_dev_ops pch_dev_ops_wpt = { · 3 unmodified lines
142141 .get_temp = pch_wpt_get_temp,
143142 };
144143
145−static int pch_thermal_get_temp(struct thermal_zone_device *tzd,
146− unsigned long *temp)
144+static int pch_thermal_get_temp(struct thermal_zone_device *tzd, int *temp)
147145 {
148146 struct pch_thermal_device *ptd = tzd->devdata;
149147
@@ -165,8 +163,7 @@ static int pch_get_trip_type(struct thermal_zone_device *tzd, int trip, · 15 unmodified lines
165163 return 0;
166164 }
167165
168−static int pch_get_trip_temp(struct thermal_zone_device *tzd, int trip,
169− unsigned long *temp)
166+static int pch_get_trip_temp(struct thermal_zone_device *tzd, int trip, int *temp)
170167 {
171168 struct pch_thermal_device *ptd = tzd->devdata;
172169