History

drivers/block/brd.c: fix brd_lookup_page() race

The index on the page must be set before it is inserted in the radix tree. Otherwise there is a small race which can occur during lookup where the page can be found with the incorrect index. This will trigger the BUG_ON() in brd_lookup_page().

Brian Behlendorf committed 13 years ago

Commit dfd20b21 parent e5ee7301 file · +2 −2Browse files

Unified · Split

drivers/block/brd.c+2−2
@@ -117,13 +117,13 @@ static struct page *brd_insert_page(struct brd_device *brd, sector_t sector) · 116 unmodified lines
117 117
118 spin_lock(&brd->brd_lock);118 spin_lock(&brd->brd_lock);
119 idx = sector >> PAGE_SECTORS_SHIFT;119 idx = sector >> PAGE_SECTORS_SHIFT;
120 page->index = idx;
120 if (radix_tree_insert(&brd->brd_pages, idx, page)) {121 if (radix_tree_insert(&brd->brd_pages, idx, page)) {
121 __free_page(page);122 __free_page(page);
122 page = radix_tree_lookup(&brd->brd_pages, idx);123 page = radix_tree_lookup(&brd->brd_pages, idx);
123 BUG_ON(!page);124 BUG_ON(!page);
124 BUG_ON(page->index != idx);125 BUG_ON(page->index != idx);
125 } else126 }
126 page->index = idx;
127 spin_unlock(&brd->brd_lock);127 spin_unlock(&brd->brd_lock);
128 128
129 radix_tree_preload_end();129 radix_tree_preload_end();

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t