History

ethtool: make validate_speed accept all speeds between 0 and INT_MAX

Devices these days can have any speed and as was recently pointed out any speed from 0 to INT_MAX is valid so adjust speed validation to accept such values.

Nikolay Aleksandrov committed 10 years ago

Commit e02564e1 parent 83840f51 file · +1 −18Browse files

Showing the changes to include/uapi (1 of 1 file). Show all

Unified · Split

include/uapi/linux/ethtool.h+1−18
@@ -1377,24 +1377,7 @@ enum ethtool_sfeatures_retval_bits { · 1376 unmodified lines
13771377
13781378 static inline int ethtool_validate_speed(__u32 speed)
13791379 {
1380− switch (speed) {
1381− case SPEED_10:
1382− case SPEED_100:
1383− case SPEED_1000:
1384− case SPEED_2500:
1385− case SPEED_5000:
1386− case SPEED_10000:
1387− case SPEED_20000:
1388− case SPEED_25000:
1389− case SPEED_40000:
1390− case SPEED_50000:
1391− case SPEED_56000:
1392− case SPEED_100000:
1393− case SPEED_UNKNOWN:
1394− return 1;
1395− }
1396−
1397− return 0;
1380+ return speed <= INT_MAX || speed == SPEED_UNKNOWN;
13981381 }
13991382
14001383 /* Duplex, half or full. */

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t