__ab_c_size() is a somewhat opaque name. Document its purpose, and while at it, rename the parameters to actually match the abc naming. [ bp: glued a complete patch from chunks on LKML. ]
Showing the changes to include/linux (1 of 1 file). Show all
Unified · Split
| @@ -278,11 +278,15 @@ static inline __must_check size_t array3_size(size_t a, size_t b, size_t c) · 277 unmodified lines | ||
| 278 | 278 | return bytes; |
| 279 | 279 | } |
| 280 | 280 | |
| 281 | −static inline __must_check size_t __ab_c_size(size_t n, size_t size, size_t c) | |
| 281 | +/* | |
| 282 | + * Compute a*b+c, returning SIZE_MAX on overflow. Internal helper for | |
| 283 | + * struct_size() below. | |
| 284 | + */ | |
| 285 | +static inline __must_check size_t __ab_c_size(size_t a, size_t b, size_t c) | |
| 282 | 286 | { |
| 283 | 287 | size_t bytes; |
| 284 | 288 | |
| 285 | − if (check_mul_overflow(n, size, &bytes)) | |
| 289 | + if (check_mul_overflow(a, b, &bytes)) | |
| 286 | 290 | return SIZE_MAX; |
| 287 | 291 | if (check_add_overflow(bytes, c, &bytes)) |
| 288 | 292 | return SIZE_MAX; |