History

locks: pass correct "before" pointer to locks_unlink_lock in generic_add_lease

The argument to locks_unlink_lock can't be just any pointer to a pointer. It must be a pointer to the fl_next field in the previous lock in the list.

Jeff Layton committed 12 years ago

Commit e0b760f1 parent 53178211 file · +1 −1Browse files

Unified · Split

fs/locks.c+1−1
@@ -1619,7 +1619,7 @@ static int generic_add_lease(struct file *filp, long arg, struct file_lock **flp · 1618 unmodified lines
16191619 smp_mb();
16201620 error = check_conflicting_open(dentry, arg);
16211621 if (error)
1622− locks_unlink_lock(flp);
1622+ locks_unlink_lock(before);
16231623 out:
16241624 if (is_deleg)
16251625 mutex_unlock(&inode->i_mutex);

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t