History

tcp: Fix a data-race around sysctl_tcp_min_tso_segs.

While reading sysctl_tcp_min_tso_segs, it can be changed concurrently. Thus, we need to add READ_ONCE() to its reader.

Kuniyuki Iwashima committed 4 years ago

Commit e0bb4ab1 parent db3815a1 file · +1 −1Browse files

Unified · Split

net/ipv4/tcp_output.c+1−1
@@ -1995,7 +1995,7 @@ static u32 tcp_tso_segs(struct sock *sk, unsigned int mss_now) · 1994 unmodified lines
1995 1995
1996 min_tso = ca_ops->min_tso_segs ?1996 min_tso = ca_ops->min_tso_segs ?
1997 ca_ops->min_tso_segs(sk) :1997 ca_ops->min_tso_segs(sk) :
1998 sock_net(sk)->ipv4.sysctl_tcp_min_tso_segs;1998 READ_ONCE(sock_net(sk)->ipv4.sysctl_tcp_min_tso_segs);
1999 1999
2000 tso_segs = tcp_tso_autosize(sk, mss_now, min_tso);2000 tso_segs = tcp_tso_autosize(sk, mss_now, min_tso);
2001 return min_t(u32, tso_segs, sk->sk_gso_max_segs);2001 return min_t(u32, tso_segs, sk->sk_gso_max_segs);