Since commit 1f65f947a6a8 ("checkpatch: add checks for question mark and colon spacing") back in 2008, checkpatch has reported false positive for asm volatile uses of "::" checkpatch thinks colons should always have spaces around it. Add an exception for colons with colons on either side for this valid asm volatile (and c++) use.
Showing the changes to scripts/checkpatch.pl (1 of 1 file). Show all
Unified · Split
| @@ -3845,6 +3845,14 @@ sub process { · 3844 unmodified lines | |||
| 3845 | $ok = 1; | 3845 | $ok = 1; |
| 3846 | } | 3846 | } |
| 3847 | 3847 | ||
| 3848 | # for asm volatile statements | ||
| 3849 | # ignore a colon with another | ||
| 3850 | # colon immediately before or after | ||
| 3851 | if (($op eq ':') && | ||
| 3852 | ($ca =~ /:$/ || $cc =~ /^:/)) { | ||
| 3853 | $ok = 1; | ||
| 3854 | } | ||
| 3855 | |||
| 3848 | # messages are ERROR, but ?: are CHK | 3856 | # messages are ERROR, but ?: are CHK |
| 3849 | if ($ok == 0) { | 3857 | if ($ok == 0) { |
| 3850 | my $msg_type = \&ERROR; | 3858 | my $msg_type = \&ERROR; |