History

ipmi: Make the smi watcher be disabled immediately when not needed

The code to tell the lower layer to enable or disable watching for certain things was lazy in disabling, it waited until a timer tick to see if a disable was necessary. Not a really big deal, but it could be improved. Modify the code to enable and disable watching immediately and don't do it from the background timer any more.

Corey Minyard committed 8 years ago

Commit e1891cf1 parent c65ea994 files · +96 −89Browse files

Showing the changes to include/linux (1 of 4 files). Show all

Unified · Split

include/linux/ipmi_smi.h+4−13
@@ -32,14 +32,11 @@ struct ipmi_smi; · 31 unmodified lines
3232
3333 /*
3434 * Flags for set_check_watch() below. Tells if the SMI should be
35− * waiting for watchdog timeouts, commands and/or messages. There is
36− * also an internal flag for the message handler, SMIs should ignore
37− * it.
35+ * waiting for watchdog timeouts, commands and/or messages.
3836 */
39−#define IPMI_WATCH_MASK_INTERNAL (1 << 0)
40−#define IPMI_WATCH_MASK_CHECK_MESSAGES (1 << 1)
41−#define IPMI_WATCH_MASK_CHECK_WATCHDOG (1 << 2)
42−#define IPMI_WATCH_MASK_CHECK_COMMANDS (1 << 3)
37+#define IPMI_WATCH_MASK_CHECK_MESSAGES (1 << 0)
38+#define IPMI_WATCH_MASK_CHECK_WATCHDOG (1 << 1)
39+#define IPMI_WATCH_MASK_CHECK_COMMANDS (1 << 2)
4340
4441 /*
4542 * Messages to/from the lower layer. The smi interface will take one
@@ -66,12 +63,6 @@ struct ipmi_smi_msg { · 20 unmodified lines
6663 int rsp_size;
6764 unsigned char rsp[IPMI_MAX_MSG_LENGTH];
6865
69− /*
70− * There should be a response message coming back in the BMC
71− * message queue.
72− */
73− bool needs_response;
74−
7566 /*
7667 * Will be called when the system is done with the message
7768 * (presumably to free it).

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t