All existing vendor DTSes are using "cpm_slcr" reg followed by "cfg" reg. This order is also suggested by node name which is pcie@fca10000 which suggests that cpm_slcr register should be the first. Driver itself is using devm_platform_ioremap_resource_byname() for both names that's why there is no functional change even on description which are using current order. But still prefer to change order to cover currently used description. Fixes: e22fadb1d014 ("PCI: xilinx-cpm: Add YAML schemas for Versal CPM Root Port")
Unified · Split
| @@ -18,13 +18,13 @@ properties: · 17 unmodified lines | |||
| 18 | 18 | ||
| 19 | reg: | 19 | reg: |
| 20 | items: | 20 | items: |
| 21 | - description: Configuration space region and bridge registers. | ||
| 22 | - description: CPM system level control and status registers. | 21 | - description: CPM system level control and status registers. |
| 22 | - description: Configuration space region and bridge registers. | ||
| 23 | 23 | ||
| 24 | reg-names: | 24 | reg-names: |
| 25 | items: | 25 | items: |
| 26 | - const: cfg | ||
| 27 | - const: cpm_slcr | 26 | - const: cpm_slcr |
| 27 | - const: cfg | ||
| 28 | 28 | ||
| 29 | interrupts: | 29 | interrupts: |
| 30 | maxItems: 1 | 30 | maxItems: 1 |
| @@ -86,9 +86,9 @@ examples: · 55 unmodified lines | |||
| 86 | ranges = <0x02000000 0x0 0xe0000000 0x0 0xe0000000 0x0 0x10000000>, | 86 | ranges = <0x02000000 0x0 0xe0000000 0x0 0xe0000000 0x0 0x10000000>, |
| 87 | <0x43000000 0x80 0x00000000 0x80 0x00000000 0x0 0x80000000>; | 87 | <0x43000000 0x80 0x00000000 0x80 0x00000000 0x0 0x80000000>; |
| 88 | msi-map = <0x0 &its_gic 0x0 0x10000>; | 88 | msi-map = <0x0 &its_gic 0x0 0x10000>; |
| 89 | reg = <0x6 0x00000000 0x0 0x10000000>, | 89 | reg = <0x0 0xfca10000 0x0 0x1000>, |
| 90 | <0x0 0xfca10000 0x0 0x1000>; | 90 | <0x6 0x00000000 0x0 0x10000000>; |
| 91 | reg-names = "cfg", "cpm_slcr"; | 91 | reg-names = "cpm_slcr", "cfg"; |
| 92 | pcie_intc_0: interrupt-controller { | 92 | pcie_intc_0: interrupt-controller { |
| 93 | #address-cells = <0>; | 93 | #address-cells = <0>; |
| 94 | #interrupt-cells = <1>; | 94 | #interrupt-cells = <1>; |