Including <linux/in.h> and <netinet/in.h> in the dependencies breaks compilation of trinity due to multiple definitions. <linux/in.h> is only used in <linux/icmp.h> to provide the definition of the struct in_addr, but this can be substituted out by using the datatype __be32.
Showing the changes to include/uapi (1 of 2 files). Show all
Unified · Split
| @@ -20,7 +20,6 @@ · 19 unmodified lines | ||
| 20 | 20 | |
| 21 | 21 | #include <linux/types.h> |
| 22 | 22 | #include <asm/byteorder.h> |
| 23 | −#include <linux/in.h> | |
| 24 | 23 | #include <linux/if.h> |
| 25 | 24 | #include <linux/in6.h> |
| 26 | 25 | |
| @@ -154,7 +153,7 @@ struct icmp_ext_echo_iio { · 127 unmodified lines | ||
| 154 | 153 | struct { |
| 155 | 154 | struct icmp_ext_echo_ctype3_hdr ctype3_hdr; |
| 156 | 155 | union { |
| 157 | − struct in_addr ipv4_addr; | |
| 156 | + __be32 ipv4_addr; | |
| 158 | 157 | struct in6_addr ipv6_addr; |
| 159 | 158 | } ip_addr; |
| 160 | 159 | } addr; |