History

debugfs: use specified mode to possibly mark files read/write only

In many SoC implementations there are hardware registers can be read or write only. This extends the debugfs to enforce the file permissions for these types of registers by providing a set of fops which are read or write only. This assumes that the kernel developer knows more about the hardware than the user (even root users) -- which is normally true.

Robin Getz committed 17 years ago

Commit e4792aa1 parent 156f5a71 file · +63 −0Browse files

Unified · Split

fs/debugfs/file.c+63−0
@@ -67,6 +67,8 @@ static int debugfs_u8_get(void *data, u64 *val) · 66 unmodified lines
6767 return 0;
6868 }
6969 DEFINE_SIMPLE_ATTRIBUTE(fops_u8, debugfs_u8_get, debugfs_u8_set, "%llu\n");
70+DEFINE_SIMPLE_ATTRIBUTE(fops_u8_ro, debugfs_u8_get, NULL, "%llu\n");
71+DEFINE_SIMPLE_ATTRIBUTE(fops_u8_wo, NULL, debugfs_u8_set, "%llu\n");
7072
7173 /**
7274 * debugfs_create_u8 - create a debugfs file that is used to read and write an unsigned 8-bit value
@@ -95,6 +97,13 @@ DEFINE_SIMPLE_ATTRIBUTE(fops_u8, debugfs_u8_get, debugfs_u8_set, "%llu\n"); · 22 unmodified lines
9597 struct dentry *debugfs_create_u8(const char *name, mode_t mode,
9698 struct dentry *parent, u8 *value)
9799 {
100+ /* if there are no write bits set, make read only */
101+ if (!(mode & S_IWUGO))
102+ return debugfs_create_file(name, mode, parent, value, &fops_u8_ro);
103+ /* if there are no read bits set, make write only */
104+ if (!(mode & S_IRUGO))
105+ return debugfs_create_file(name, mode, parent, value, &fops_u8_wo);
106+
98107 return debugfs_create_file(name, mode, parent, value, &fops_u8);
99108 }
100109 EXPORT_SYMBOL_GPL(debugfs_create_u8);
@@ -110,6 +119,8 @@ static int debugfs_u16_get(void *data, u64 *val) · 9 unmodified lines
110119 return 0;
111120 }
112121 DEFINE_SIMPLE_ATTRIBUTE(fops_u16, debugfs_u16_get, debugfs_u16_set, "%llu\n");
122+DEFINE_SIMPLE_ATTRIBUTE(fops_u16_ro, debugfs_u16_get, NULL, "%llu\n");
123+DEFINE_SIMPLE_ATTRIBUTE(fops_u16_wo, NULL, debugfs_u16_set, "%llu\n");
113124
114125 /**
115126 * debugfs_create_u16 - create a debugfs file that is used to read and write an unsigned 16-bit value
@@ -138,6 +149,13 @@ DEFINE_SIMPLE_ATTRIBUTE(fops_u16, debugfs_u16_get, debugfs_u16_set, "%llu\n"); · 22 unmodified lines
138149 struct dentry *debugfs_create_u16(const char *name, mode_t mode,
139150 struct dentry *parent, u16 *value)
140151 {
152+ /* if there are no write bits set, make read only */
153+ if (!(mode & S_IWUGO))
154+ return debugfs_create_file(name, mode, parent, value, &fops_u16_ro);
155+ /* if there are no read bits set, make write only */
156+ if (!(mode & S_IRUGO))
157+ return debugfs_create_file(name, mode, parent, value, &fops_u16_wo);
158+
141159 return debugfs_create_file(name, mode, parent, value, &fops_u16);
142160 }
143161 EXPORT_SYMBOL_GPL(debugfs_create_u16);
@@ -153,6 +171,8 @@ static int debugfs_u32_get(void *data, u64 *val) · 9 unmodified lines
153171 return 0;
154172 }
155173 DEFINE_SIMPLE_ATTRIBUTE(fops_u32, debugfs_u32_get, debugfs_u32_set, "%llu\n");
174+DEFINE_SIMPLE_ATTRIBUTE(fops_u32_ro, debugfs_u32_get, NULL, "%llu\n");
175+DEFINE_SIMPLE_ATTRIBUTE(fops_u32_wo, NULL, debugfs_u32_set, "%llu\n");
156176
157177 /**
158178 * debugfs_create_u32 - create a debugfs file that is used to read and write an unsigned 32-bit value
@@ -181,6 +201,13 @@ DEFINE_SIMPLE_ATTRIBUTE(fops_u32, debugfs_u32_get, debugfs_u32_set, "%llu\n"); · 22 unmodified lines
181201 struct dentry *debugfs_create_u32(const char *name, mode_t mode,
182202 struct dentry *parent, u32 *value)
183203 {
204+ /* if there are no write bits set, make read only */
205+ if (!(mode & S_IWUGO))
206+ return debugfs_create_file(name, mode, parent, value, &fops_u32_ro);
207+ /* if there are no read bits set, make write only */
208+ if (!(mode & S_IRUGO))
209+ return debugfs_create_file(name, mode, parent, value, &fops_u32_wo);
210+
184211 return debugfs_create_file(name, mode, parent, value, &fops_u32);
185212 }
186213 EXPORT_SYMBOL_GPL(debugfs_create_u32);
@@ -197,6 +224,8 @@ static int debugfs_u64_get(void *data, u64 *val) · 10 unmodified lines
197224 return 0;
198225 }
199226 DEFINE_SIMPLE_ATTRIBUTE(fops_u64, debugfs_u64_get, debugfs_u64_set, "%llu\n");
227+DEFINE_SIMPLE_ATTRIBUTE(fops_u64_ro, debugfs_u64_get, NULL, "%llu\n");
228+DEFINE_SIMPLE_ATTRIBUTE(fops_u64_wo, NULL, debugfs_u64_set, "%llu\n");
200229
201230 /**
202231 * debugfs_create_u64 - create a debugfs file that is used to read and write an unsigned 64-bit value
@@ -225,15 +254,28 @@ DEFINE_SIMPLE_ATTRIBUTE(fops_u64, debugfs_u64_get, debugfs_u64_set, "%llu\n"); · 22 unmodified lines
225254 struct dentry *debugfs_create_u64(const char *name, mode_t mode,
226255 struct dentry *parent, u64 *value)
227256 {
257+ /* if there are no write bits set, make read only */
258+ if (!(mode & S_IWUGO))
259+ return debugfs_create_file(name, mode, parent, value, &fops_u64_ro);
260+ /* if there are no read bits set, make write only */
261+ if (!(mode & S_IRUGO))
262+ return debugfs_create_file(name, mode, parent, value, &fops_u64_wo);
263+
228264 return debugfs_create_file(name, mode, parent, value, &fops_u64);
229265 }
230266 EXPORT_SYMBOL_GPL(debugfs_create_u64);
231267
232268 DEFINE_SIMPLE_ATTRIBUTE(fops_x8, debugfs_u8_get, debugfs_u8_set, "0x%02llx\n");
269+DEFINE_SIMPLE_ATTRIBUTE(fops_x8_ro, debugfs_u8_get, NULL, "0x%02llx\n");
270+DEFINE_SIMPLE_ATTRIBUTE(fops_x8_wo, NULL, debugfs_u8_set, "0x%02llx\n");
233271
234272 DEFINE_SIMPLE_ATTRIBUTE(fops_x16, debugfs_u16_get, debugfs_u16_set, "0x%04llx\n");
273+DEFINE_SIMPLE_ATTRIBUTE(fops_x16_ro, debugfs_u16_get, NULL, "0x%04llx\n");
274+DEFINE_SIMPLE_ATTRIBUTE(fops_x16_wo, NULL, debugfs_u16_set, "0x%04llx\n");
235275
236276 DEFINE_SIMPLE_ATTRIBUTE(fops_x32, debugfs_u32_get, debugfs_u32_set, "0x%08llx\n");
277+DEFINE_SIMPLE_ATTRIBUTE(fops_x32_ro, debugfs_u32_get, NULL, "0x%08llx\n");
278+DEFINE_SIMPLE_ATTRIBUTE(fops_x32_wo, NULL, debugfs_u32_set, "0x%08llx\n");
237279
238280 /*
239281 * debugfs_create_x{8,16,32} - create a debugfs file that is used to read and write an unsigned {8,16,32}-bit value
@@ -256,6 +298,13 @@ DEFINE_SIMPLE_ATTRIBUTE(fops_x32, debugfs_u32_get, debugfs_u32_set, "0x%08llx\n" · 16 unmodified lines
256298 struct dentry *debugfs_create_x8(const char *name, mode_t mode,
257299 struct dentry *parent, u8 *value)
258300 {
301+ /* if there are no write bits set, make read only */
302+ if (!(mode & S_IWUGO))
303+ return debugfs_create_file(name, mode, parent, value, &fops_x8_ro);
304+ /* if there are no read bits set, make write only */
305+ if (!(mode & S_IRUGO))
306+ return debugfs_create_file(name, mode, parent, value, &fops_x8_wo);
307+
259308 return debugfs_create_file(name, mode, parent, value, &fops_x8);
260309 }
261310 EXPORT_SYMBOL_GPL(debugfs_create_x8);
@@ -273,6 +322,13 @@ EXPORT_SYMBOL_GPL(debugfs_create_x8); · 11 unmodified lines
273322 struct dentry *debugfs_create_x16(const char *name, mode_t mode,
274323 struct dentry *parent, u16 *value)
275324 {
325+ /* if there are no write bits set, make read only */
326+ if (!(mode & S_IWUGO))
327+ return debugfs_create_file(name, mode, parent, value, &fops_x16_ro);
328+ /* if there are no read bits set, make write only */
329+ if (!(mode & S_IRUGO))
330+ return debugfs_create_file(name, mode, parent, value, &fops_x16_wo);
331+
276332 return debugfs_create_file(name, mode, parent, value, &fops_x16);
277333 }
278334 EXPORT_SYMBOL_GPL(debugfs_create_x16);
@@ -290,6 +346,13 @@ EXPORT_SYMBOL_GPL(debugfs_create_x16); · 11 unmodified lines
290346 struct dentry *debugfs_create_x32(const char *name, mode_t mode,
291347 struct dentry *parent, u32 *value)
292348 {
349+ /* if there are no write bits set, make read only */
350+ if (!(mode & S_IWUGO))
351+ return debugfs_create_file(name, mode, parent, value, &fops_x32_ro);
352+ /* if there are no read bits set, make write only */
353+ if (!(mode & S_IRUGO))
354+ return debugfs_create_file(name, mode, parent, value, &fops_x32_wo);
355+
293356 return debugfs_create_file(name, mode, parent, value, &fops_x32);
294357 }
295358 EXPORT_SYMBOL_GPL(debugfs_create_x32);

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t