History

calloc/xcalloc: Fix argument order

The calloc() and xcalloc() functions takes @nmemb first and then @size. Fix all w/ pattern "calloc\s*(\s*sizeof".

Arjun Sreedharan committed 11 years ago

Commit e4e458b1 parent 2e777843 files · +7 −7Browse files

Unified · Split

3 files
  1. scripts/kconfig/mconf.c +2 −2
  2. tools/perf/ui/hist.c +2 −2
  3. tools/thermal/tmon/sysfs.c +3 −3
scripts/kconfig/mconf.c+2−2
@@ -330,10 +330,10 @@ static void set_subtitle(void) · 329 unmodified lines
330330 list_for_each_entry(sp, &trail, entries) {
331331 if (sp->text) {
332332 if (pos) {
333− pos->next = xcalloc(sizeof(*pos), 1);
333+ pos->next = xcalloc(1, sizeof(*pos));
334334 pos = pos->next;
335335 } else {
336− subtitles = pos = xcalloc(sizeof(*pos), 1);
336+ subtitles = pos = xcalloc(1, sizeof(*pos));
337337 }
338338 pos->text = sp->text;
339339 }
tools/perf/ui/hist.c+2−2
@@ -162,8 +162,8 @@ static int __hpp__sort(struct hist_entry *a, struct hist_entry *b, · 161 unmodified lines
162162 return ret;
163163
164164 nr_members = evsel->nr_members;
165− fields_a = calloc(sizeof(*fields_a), nr_members);
166− fields_b = calloc(sizeof(*fields_b), nr_members);
165+ fields_a = calloc(nr_members, sizeof(*fields_a));
166+ fields_b = calloc(nr_members, sizeof(*fields_b));
167167
168168 if (!fields_a || !fields_b)
169169 goto out;
tools/thermal/tmon/sysfs.c+3−3
@@ -446,7 +446,7 @@ int probe_thermal_sysfs(void) · 445 unmodified lines
446446 return -1;
447447 }
448448
449− ptdata.tzi = calloc(sizeof(struct tz_info), ptdata.max_tz_instance+1);
449+ ptdata.tzi = calloc(ptdata.max_tz_instance+1, sizeof(struct tz_info));
450450 if (!ptdata.tzi) {
451451 fprintf(stderr, "Err: allocate tz_info\n");
452452 return -1;
@@ -454,8 +454,8 @@ int probe_thermal_sysfs(void) · 1 unmodified line
454454
455455 /* we still show thermal zone information if there is no cdev */
456456 if (ptdata.nr_cooling_dev) {
457− ptdata.cdi = calloc(sizeof(struct cdev_info),
458− ptdata.max_cdev_instance + 1);
457+ ptdata.cdi = calloc(ptdata.max_cdev_instance + 1,
458+ sizeof(struct cdev_info));
459459 if (!ptdata.cdi) {
460460 free(ptdata.tzi);
461461 fprintf(stderr, "Err: allocate cdev_info\n");