The driver supports passing some GPIO lines for rows and columns through the driver data, but there is no in-kernel user of this. Further the use seems convoluted because the GPIO lines are unused in the driver, then explicitly free:ed when removing it without being requested when probing it, which is assymetric and just a recepie for disaster. Remove the support for these unused GPIOs, if need be support can be reestablished in an organized fashion using GPIO descriptors.
Showing the changes to include/linux/platform_data (1 of 2 files). Show all
Unified · Split
| @@ -19,9 +19,6 @@ struct omap_kp_platform_data { · 18 unmodified lines | |||
| 19 | bool rep; | 19 | bool rep; |
| 20 | unsigned long delay; | 20 | unsigned long delay; |
| 21 | bool dbounce; | 21 | bool dbounce; |
| 22 | /* specific to OMAP242x*/ | ||
| 23 | unsigned int *row_gpios; | ||
| 24 | unsigned int *col_gpios; | ||
| 25 | }; | 22 | }; |
| 26 | 23 | ||
| 27 | /* Group (0..3) -- when multiple keys are pressed, only the | 24 | /* Group (0..3) -- when multiple keys are pressed, only the |