add_root_to_dirty_list happens once at the very beginning of the transaction, but it is still racey.
Unified · Split
| @@ -220,10 +220,12 @@ struct extent_buffer *btrfs_read_lock_root_node(struct btrfs_root *root) · 219 unmodified lines | ||
| 220 | 220 | */ |
| 221 | 221 | static void add_root_to_dirty_list(struct btrfs_root *root) |
| 222 | 222 | { |
| 223 | + spin_lock(&root->fs_info->trans_lock); | |
| 223 | 224 | if (root->track_dirty && list_empty(&root->dirty_list)) { |
| 224 | 225 | list_add(&root->dirty_list, |
| 225 | 226 | &root->fs_info->dirty_cowonly_roots); |
| 226 | 227 | } |
| 228 | + spin_unlock(&root->fs_info->trans_lock); | |
| 227 | 229 | } |
| 228 | 230 | |
| 229 | 231 | /* |