History

proc: use named enums for better readability

Alexey Gladkov committed 6 years ago

Commit e61bb8b1 parent 1c6c4d14 files · +8 −8Browse files

Unified · Split

4 files
  1. fs/proc/base.c +1 −1
  2. fs/proc/inode.c +1 −1
  3. fs/proc/root.c +2 −2
  4. include/linux/proc_fs.h +4 −4
fs/proc/base.c+1−1
@@ -699,7 +699,7 @@ int proc_setattr(struct dentry *dentry, struct iattr *attr) · 698 unmodified lines
699 */699 */
700static bool has_pid_permissions(struct proc_fs_info *fs_info,700static bool has_pid_permissions(struct proc_fs_info *fs_info,
701 struct task_struct *task,701 struct task_struct *task,
702 int hide_pid_min)702 enum proc_hidepid hide_pid_min)
703{703{
704 /*704 /*
705 * If 'hidpid' mount option is set force a ptrace check,705 * If 'hidpid' mount option is set force a ptrace check,
fs/proc/inode.c+1−1
@@ -166,7 +166,7 @@ void proc_invalidate_siblings_dcache(struct hlist_head *inodes, spinlock_t *lock · 165 unmodified lines
166 deactivate_super(old_sb);166 deactivate_super(old_sb);
167}167}
168 168
169static inline const char *hidepid2str(int v)169static inline const char *hidepid2str(enum proc_hidepid v)
170{170{
171 switch (v) {171 switch (v) {
172 case HIDEPID_OFF: return "off";172 case HIDEPID_OFF: return "off";
fs/proc/root.c+2−2
@@ -32,9 +32,9 @@ · 31 unmodified lines
32struct proc_fs_context {32struct proc_fs_context {
33 struct pid_namespace *pid_ns;33 struct pid_namespace *pid_ns;
34 unsigned int mask;34 unsigned int mask;
35 int hidepid;35 enum proc_hidepid hidepid;
36 int gid;36 int gid;
37 int pidonly;37 enum proc_pidonly pidonly;
38};38};
39 39
40enum proc_param {40enum proc_param {
include/linux/proc_fs.h+4−4
@@ -43,7 +43,7 @@ struct proc_ops { · 42 unmodified lines
43} __randomize_layout;43} __randomize_layout;
44 44
45/* definitions for hide_pid field */45/* definitions for hide_pid field */
46enum {46enum proc_hidepid {
47 HIDEPID_OFF = 0,47 HIDEPID_OFF = 0,
48 HIDEPID_NO_ACCESS = 1,48 HIDEPID_NO_ACCESS = 1,
49 HIDEPID_INVISIBLE = 2,49 HIDEPID_INVISIBLE = 2,
@@ -51,7 +51,7 @@ enum { · 1 unmodified line
51};51};
52 52
53/* definitions for proc mount option pidonly */53/* definitions for proc mount option pidonly */
54enum {54enum proc_pidonly {
55 PROC_PIDONLY_OFF = 0,55 PROC_PIDONLY_OFF = 0,
56 PROC_PIDONLY_ON = 1,56 PROC_PIDONLY_ON = 1,
57};57};
@@ -61,8 +61,8 @@ struct proc_fs_info { · 3 unmodified lines
61 struct dentry *proc_self; /* For /proc/self */61 struct dentry *proc_self; /* For /proc/self */
62 struct dentry *proc_thread_self; /* For /proc/thread-self */62 struct dentry *proc_thread_self; /* For /proc/thread-self */
63 kgid_t pid_gid;63 kgid_t pid_gid;
64 int hide_pid;64 enum proc_hidepid hide_pid;
65 int pidonly;65 enum proc_pidonly pidonly;
66};66};
67 67
68static inline struct proc_fs_info *proc_sb_info(struct super_block *sb)68static inline struct proc_fs_info *proc_sb_info(struct super_block *sb)