History

drm/i915: Remove i915_gem_execbuffer_retire_commands()

Move the single line to the callsite as the name is now misleading, and the purpose is solely to add the request to the execution queue. Here, we can see that if we failed to dispatch the batch from the request, we can forgo flushing the GPU when closing the request.

Chris Wilson committed 10 years ago

Commit e655bc31 parent 0340d9f1 file · +1 −8Browse files

Unified · Split

drivers/gpu/drm/i915/i915_gem_execbuffer.c+1−8
@@ -1211,13 +1211,6 @@ i915_gem_execbuffer_move_to_active(struct list_head *vmas, · 1210 unmodified lines
1211 }1211 }
1212}1212}
1213 1213
1214static void
1215i915_gem_execbuffer_retire_commands(struct i915_execbuffer_params *params)
1216{
1217 /* Add a breadcrumb for the completion of the batch buffer */
1218 __i915_add_request(params->request, params->batch_obj, true);
1219}
1220
1221static int1214static int
1222i915_reset_gen7_sol_offsets(struct drm_i915_gem_request *req)1215i915_reset_gen7_sol_offsets(struct drm_i915_gem_request *req)
1223{1216{
@@ -1692,7 +1685,7 @@ i915_gem_do_execbuffer(struct drm_device *dev, void *data, · 468 unmodified lines
1692 1685
1693 ret = execbuf_submit(params, args, &eb->vmas);1686 ret = execbuf_submit(params, args, &eb->vmas);
1694err_request:1687err_request:
1695 i915_gem_execbuffer_retire_commands(params);1688 __i915_add_request(params->request, params->batch_obj, ret == 0);
1696 1689
1697err_batch_unpin:1690err_batch_unpin:
1698 /*1691 /*

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t