History

gpio: gpio-omap: configure edge detection for level IRQs for idle wakeup

The GPIO block can enter idle independently of the CPU power management calls via smart-idle. When the GPIO block enters idle, level detection stops working due to clocks being shut off, and an alternative form of edge detection is used. However, this needs the edge detection registers set to mark the appropriate edges. Arrange to configure the edge detection enables along with the level detection to ensure that any transition to active interrupt state that occurs while the block is idle is detected as a wake-up event. Since we enable the edge detection when configuring the IRQ, both omap2_gpio_enable_level_quirk() nor omap2_gpio_disable_level_quirk() become redundant, which also means OMAP_GPIO_QUIRK_IDLE_REMOVE_TRIGGER can be removed. This can be now done without regressions as patch "gpio: gpio-omap: fix level interrupt idling" allows level interrupts to idle on omap4 without a workaround.

Russell King committed 7 years ago

Commit e6818d21 parent 4779a062 files · +11 −81Browse files

Showing the changes to include/linux (1 of 2 files). Show all

Unified · Split

include/linux/platform_data/gpio-omap.h+0−2
@@ -200,8 +200,6 @@ struct omap_gpio_platform_data { · 199 unmodified lines
200 bool is_mpuio; /* whether the bank is of type MPUIO */200 bool is_mpuio; /* whether the bank is of type MPUIO */
201 u32 non_wakeup_gpios;201 u32 non_wakeup_gpios;
202 202
203 u32 quirks; /* Version specific quirks mask */
204
205 struct omap_gpio_reg_offs *regs;203 struct omap_gpio_reg_offs *regs;
206 204
207 /* Return context loss count due to PM states changing */205 /* Return context loss count due to PM states changing */

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t