History

kbuild: refactor headers_* targets in Makefile

o Use lower case for local variables o Add a helper target for common targets o Use $(hdr-inst)= ... to make Make invocations simpler o Add -rR to make invocations In total this adds more lines than it removes but the benefit is better readability

Sam Ravnborg committed 18 years ago

Commit e6883b11 parent 50478871 file · +23 −16Browse files

Unified · Split

Makefile+23−16
@@ -1010,36 +1010,43 @@ firmware_install: FORCE · 1009 unmodified lines
1010 1010
1011# ---------------------------------------------------------------------------1011# ---------------------------------------------------------------------------
1012# Kernel headers1012# Kernel headers
1013INSTALL_HDR_PATH=$(objtree)/usr
1014export INSTALL_HDR_PATH
1015 1013
1016HDRFILTER=generic i386 x86_641014#Default location for installed headers
1017HDRARCHES=$(filter-out $(HDRFILTER),$(patsubst $(srctree)/include/asm-%/Kbuild,%,$(wildcard $(srctree)/include/asm-*/Kbuild)))1015export INSTALL_HDR_PATH = $(objtree)/usr
1018 1016
1019PHONY += headers_install_all1017hdr-filter := generic um ppc
1020headers_install_all: include/linux/version.h scripts_basic FORCE1018hdr-archs := $(filter-out $(hdr-filter), \
1019 $(patsubst $(srctree)/include/asm-%/Kbuild,%, \
1020 $(wildcard $(srctree)/include/asm-*/Kbuild)))
1021hdr-inst := -rR -f $(srctree)/scripts/Makefile.headersinst obj
1022
1023PHONY += __headers
1024__headers: include/linux/version.h scripts_basic FORCE
1021 $(Q)$(MAKE) $(build)=scripts scripts/unifdef1025 $(Q)$(MAKE) $(build)=scripts scripts/unifdef
1022 $(Q)for arch in $(HDRARCHES); do \1026
1023 $(MAKE) ARCH=$$arch -f $(srctree)/scripts/Makefile.headersinst obj=include BIASMDIR=-bi-$$arch ;\1027PHONY += headers_install_all
1028headers_install_all: __headers
1029 $(Q)for arch in $(hdr-archs); do \
1030 $(MAKE) ARCH=$$arch $(hdr-inst)=include BIASMDIR=-bi-$$arch ;\
1024 done1031 done
1025 1032
1026PHONY += headers_install1033PHONY += headers_install
1027headers_install: include/linux/version.h scripts_basic FORCE1034headers_install: __headers
1028 @if [ ! -r $(srctree)/include/asm-$(SRCARCH)/Kbuild ]; then \1035 $(Q)if [ ! -r $(srctree)/include/asm-$(SRCARCH)/Kbuild ]; then \
1029 echo '*** Error: Headers not exportable for this architecture ($(SRCARCH))'; \1036 echo '*** Error: Headers not exportable for this architecture ($(SRCARCH))'; \
1030 exit 1 ; fi1037 exit 1 ; \
1031 $(Q)$(MAKE) $(build)=scripts scripts/unifdef1038 fi
1032 $(Q)$(MAKE) -f $(srctree)/scripts/Makefile.headersinst ARCH=$(SRCARCH) obj=include1039 $(Q)$(MAKE) $(hdr-inst)=include ARCH=$(SRCARCH)
1033 1040
1034PHONY += headers_check_all1041PHONY += headers_check_all
1035headers_check_all: headers_install_all1042headers_check_all: headers_install_all
1036 $(Q)for arch in $(HDRARCHES); do \1043 $(Q)for arch in $(hdr-archs); do \
1037 $(MAKE) ARCH=$$arch -f $(srctree)/scripts/Makefile.headersinst obj=include BIASMDIR=-bi-$$arch HDRCHECK=1 ;\1044 $(MAKE) ARCH=$$arch $(hdr-inst)=include BIASMDIR=-bi-$$arch HDRCHECK=1 ;\
1038 done1045 done
1039 1046
1040PHONY += headers_check1047PHONY += headers_check
1041headers_check: headers_install1048headers_check: headers_install
1042 $(Q)$(MAKE) -f $(srctree)/scripts/Makefile.headersinst ARCH=$(SRCARCH) obj=include HDRCHECK=11049 $(Q)$(MAKE) $(hdr-inst)=include ARCH=$(SRCARCH) HDRCHECK=1
1043 1050
1044# ---------------------------------------------------------------------------1051# ---------------------------------------------------------------------------
1045# Modules1052# Modules

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t