Motivated by review comments from Ville&Sean.
Unified · Split
| @@ -339,6 +339,16 @@ Some of these date from the very introduction of KMS in 2008 ... · 338 unmodified lines | |||
| 339 | leftovers from older (never merged into upstream) KMS designs where modes | 339 | leftovers from older (never merged into upstream) KMS designs where modes |
| 340 | where set using their ID, including support to add/remove modes. | 340 | where set using their ID, including support to add/remove modes. |
| 341 | 341 | ||
| 342 | - Make ->funcs and ->helper_private vtables optional. There's a bunch of empty | ||
| 343 | function tables in drivers, but before we can remove them we need to make sure | ||
| 344 | that all the users in helpers and drivers do correctly check for a NULL | ||
| 345 | vtable. | ||
| 346 | |||
| 347 | - Cleanup up the various ->destroy callbacks. A lot of them just wrapt the | ||
| 348 | drm_*_cleanup implementations and can be removed. Some tack a kfree() at the | ||
| 349 | end, for which we could add drm_*_cleanup_kfree(). And then there's the (for | ||
| 350 | historical reasons) misnamed drm_primary_helper_destroy() function. | ||
| 351 | |||
| 342 | Better Testing | 352 | Better Testing |
| 343 | ============== | 353 | ============== |
| 344 | 354 | ||