When an ethernet frame is padded to meet the minimum ethernet frame size, the padding octets are not covered by the hardware checksum. Fortunately the padding octets are usually zero's, which don't affect checksum. However, we have a switch which pads non-zero octets, this causes kernel hardware checksum fault repeatedly. Prior to: commit '88078d98d1bb ("net: pskb_trim_rcsum() and CHECKSUM_COMPLETE ...")' skb checksum was forced to be CHECKSUM_NONE when padding is detected. After it, we need to keep skb->csum updated, like what we do for RXFCS. However, fixing up CHECKSUM_COMPLETE requires to verify and parse IP headers, it is not worthy the effort as the packets are so small that CHECKSUM_COMPLETE can't save anything.
Unified · Split
| @@ -732,6 +732,8 @@ static u8 get_ip_proto(struct sk_buff *skb, int network_depth, __be16 proto) · 731 unmodified lines | |||
| 732 | ((struct ipv6hdr *)ip_p)->nexthdr; | 732 | ((struct ipv6hdr *)ip_p)->nexthdr; |
| 733 | } | 733 | } |
| 734 | 734 | ||
| 735 | #define short_frame(size) ((size) <= ETH_ZLEN + ETH_FCS_LEN) | ||
| 736 | |||
| 735 | static inline void mlx5e_handle_csum(struct net_device *netdev, | 737 | static inline void mlx5e_handle_csum(struct net_device *netdev, |
| 736 | struct mlx5_cqe64 *cqe, | 738 | struct mlx5_cqe64 *cqe, |
| 737 | struct mlx5e_rq *rq, | 739 | struct mlx5e_rq *rq, |
| @@ -754,6 +756,17 @@ static inline void mlx5e_handle_csum(struct net_device *netdev, · 16 unmodified lines | |||
| 754 | if (unlikely(test_bit(MLX5E_RQ_STATE_NO_CSUM_COMPLETE, &rq->state))) | 756 | if (unlikely(test_bit(MLX5E_RQ_STATE_NO_CSUM_COMPLETE, &rq->state))) |
| 755 | goto csum_unnecessary; | 757 | goto csum_unnecessary; |
| 756 | 758 | ||
| 759 | /* CQE csum doesn't cover padding octets in short ethernet | ||
| 760 | * frames. And the pad field is appended prior to calculating | ||
| 761 | * and appending the FCS field. | ||
| 762 | * | ||
| 763 | * Detecting these padded frames requires to verify and parse | ||
| 764 | * IP headers, so we simply force all those small frames to be | ||
| 765 | * CHECKSUM_UNNECESSARY even if they are not padded. | ||
| 766 | */ | ||
| 767 | if (short_frame(skb->len)) | ||
| 768 | goto csum_unnecessary; | ||
| 769 | |||
| 757 | if (likely(is_last_ethertype_ip(skb, &network_depth, &proto))) { | 770 | if (likely(is_last_ethertype_ip(skb, &network_depth, &proto))) { |
| 758 | if (unlikely(get_ip_proto(skb, network_depth, proto) == IPPROTO_SCTP)) | 771 | if (unlikely(get_ip_proto(skb, network_depth, proto) == IPPROTO_SCTP)) |
| 759 | goto csum_unnecessary; | 772 | goto csum_unnecessary; |