* 'fix/hda' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6: ALSA: hda - use WARN_ON_ONCE() for zero-division detection
Unified · Split
| @@ -1893,12 +1893,9 @@ static int azx_position_ok(struct azx *chip, struct azx_dev *azx_dev) · 1892 unmodified lines | ||
| 1893 | 1893 | |
| 1894 | 1894 | if (!bdl_pos_adj[chip->dev_index]) |
| 1895 | 1895 | return 1; /* no delayed ack */ |
| 1896 | − if (azx_dev->period_bytes == 0) { | |
| 1897 | − printk(KERN_WARNING | |
| 1898 | − "hda-intel: Divide by zero was avoided " | |
| 1899 | − "in azx_dev->period_bytes.\n"); | |
| 1900 | − return 0; | |
| 1901 | − } | |
| 1896 | + if (WARN_ONCE(!azx_dev->period_bytes, | |
| 1897 | + "hda-intel: zero azx_dev->period_bytes")) | |
| 1898 | + return 0; /* this shouldn't happen! */ | |
| 1902 | 1899 | if (pos % azx_dev->period_bytes > azx_dev->period_bytes / 2) |
| 1903 | 1900 | return 0; /* NG - it's below the period boundary */ |
| 1904 | 1901 | return 1; /* OK, it's fine */ |