This doesn't change behavior at all. In the original code, if nwords was zero then ddebug_parse_query() would return -EINVAL, now we just do it earlier.
Unified · Split
| @@ -456,7 +456,7 @@ static ssize_t ddebug_proc_write(struct file *file, const char __user *ubuf, · 455 unmodified lines | |||
| 456 | __func__, (int)len); | 456 | __func__, (int)len); |
| 457 | 457 | ||
| 458 | nwords = ddebug_tokenize(tmpbuf, words, MAXWORDS); | 458 | nwords = ddebug_tokenize(tmpbuf, words, MAXWORDS); |
| 459 | if (nwords < 0) | 459 | if (nwords <= 0) |
| 460 | return -EINVAL; | 460 | return -EINVAL; |
| 461 | if (ddebug_parse_query(words, nwords-1, &query)) | 461 | if (ddebug_parse_query(words, nwords-1, &query)) |
| 462 | return -EINVAL; | 462 | return -EINVAL; |