History

openvswitch: change type of UPCALL_PID attribute to NLA_UNSPEC

userspace openvswitch patch "(dpif-linux: Implement the API functions to allow multiple handler threads read upcall)" changes its type from U32 to UNSPEC, but leave the kernel unchanged and after kernel 6e237d099fac "(netlink: Relax attr validation for fixed length types)", this bug is exposed by the below warning [ 57.215841] netlink: 'ovs-vswitchd': attribute type 5 has an invalid length.

Li RongQing committed 7 years ago

Commit ea8564c1 parent c1d419d1 file · +1 −1Browse files

Showing the changes to net/openvswitch (1 of 1 file). Show all

Unified · Split

net/openvswitch/datapath.c+1−1
@@ -2294,7 +2294,7 @@ static const struct nla_policy vport_policy[OVS_VPORT_ATTR_MAX + 1] = { · 2293 unmodified lines
22942294 [OVS_VPORT_ATTR_STATS] = { .len = sizeof(struct ovs_vport_stats) },
22952295 [OVS_VPORT_ATTR_PORT_NO] = { .type = NLA_U32 },
22962296 [OVS_VPORT_ATTR_TYPE] = { .type = NLA_U32 },
2297− [OVS_VPORT_ATTR_UPCALL_PID] = { .type = NLA_U32 },
2297+ [OVS_VPORT_ATTR_UPCALL_PID] = { .type = NLA_UNSPEC },
22982298 [OVS_VPORT_ATTR_OPTIONS] = { .type = NLA_NESTED },
22992299 [OVS_VPORT_ATTR_IFINDEX] = { .type = NLA_U32 },
23002300 [OVS_VPORT_ATTR_NETNSID] = { .type = NLA_S32 },

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t