Pptp driver has lots of byte order warnings from sparse. This was because the on-the-wire header is in network byte order (obviously) but the definition did not reflect that. Also, the address structure to user space actually put the call id in host order. Rather than break ABI compatibility, just acknowledge the existing design.
Showing the changes to include/uapi/linux (1 of 2 files). Show all
Unified · Split
| @@ -46,7 +46,7 @@ struct pppoe_addr { · 45 unmodified lines | |||
| 46 | * PPTP addressing definition | 46 | * PPTP addressing definition |
| 47 | */ | 47 | */ |
| 48 | struct pptp_addr { | 48 | struct pptp_addr { |
| 49 | __be16 call_id; | 49 | __u16 call_id; |
| 50 | struct in_addr sin_addr; | 50 | struct in_addr sin_addr; |
| 51 | }; | 51 | }; |
| 52 | 52 | ||