History

module: Ignore _GLOBAL_OFFSET_TABLE_ when warning for undefined symbols

clang-12 -fno-pic (since https://github.com/llvm/llvm-project/commit/a084c0388e2a59b9556f2de0083333232da3f1d6) can emit `call __stack_chk_fail@PLT` instead of `call __stack_chk_fail` on x86. The two forms should have identical behaviors on x86-64 but the former causes GNU as<2.37 to produce an unreferenced undefined symbol _GLOBAL_OFFSET_TABLE_. (On x86-32, there is an R_386_PC32 vs R_386_PLT32 difference but the linker behavior is identical as far as Linux kernel is concerned.) Simply ignore _GLOBAL_OFFSET_TABLE_ for now, like what scripts/mod/modpost.c:ignore_undef_symbol does. This also fixes the problem for gcc/clang -fpie and -fpic, which may emit `call foo@PLT` for external function calls on x86. Note: ld -z defs and dynamic loaders do not error for unreferenced undefined symbols so the module loader is reading too much. If we ever need to ignore more symbols, the code should be refactored to ignore unreferenced symbols.

Fangrui Song committed 5 years ago

Commit ebfac7b1 parent 19c329f1 file · +19 −2Browse files

Unified · Split

kernel/module.c+19−2
@@ -2348,6 +2348,21 @@ static int verify_exported_symbols(struct module *mod) · 2347 unmodified lines
2348 return 0;2348 return 0;
2349}2349}
2350 2350
2351static bool ignore_undef_symbol(Elf_Half emachine, const char *name)
2352{
2353 /*
2354 * On x86, PIC code and Clang non-PIC code may have call foo@PLT. GNU as
2355 * before 2.37 produces an unreferenced _GLOBAL_OFFSET_TABLE_ on x86-64.
2356 * i386 has a similar problem but may not deserve a fix.
2357 *
2358 * If we ever have to ignore many symbols, consider refactoring the code to
2359 * only warn if referenced by a relocation.
2360 */
2361 if (emachine == EM_386 || emachine == EM_X86_64)
2362 return !strcmp(name, "_GLOBAL_OFFSET_TABLE_");
2363 return false;
2364}
2365
2351/* Change all symbols so that st_value encodes the pointer directly. */2366/* Change all symbols so that st_value encodes the pointer directly. */
2352static int simplify_symbols(struct module *mod, const struct load_info *info)2367static int simplify_symbols(struct module *mod, const struct load_info *info)
2353{2368{
@@ -2395,8 +2410,10 @@ static int simplify_symbols(struct module *mod, const struct load_info *info) · 41 unmodified lines
2395 break;2410 break;
2396 }2411 }
2397 2412
2398 /* Ok if weak. */2413 /* Ok if weak or ignored. */
2399 if (!ksym && ELF_ST_BIND(sym[i].st_info) == STB_WEAK)2414 if (!ksym &&
2415 (ELF_ST_BIND(sym[i].st_info) == STB_WEAK ||
2416 ignore_undef_symbol(info->hdr->e_machine, name)))
2400 break;2417 break;
2401 2418
2402 ret = PTR_ERR(ksym) ?: -ENOENT;2419 ret = PTR_ERR(ksym) ?: -ENOENT;

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t