extern is implied and is not needed in the header file. Remove the extern keyword and re-align the code.
Showing the changes to include/linux (1 of 1 file). Show all
Unified · Split
| @@ -161,7 +161,7 @@ struct led_classdev { · 160 unmodified lines | ||
| 161 | 161 | * |
| 162 | 162 | * Returns: 0 on success or negative error value on failure |
| 163 | 163 | */ |
| 164 | −extern int led_classdev_register_ext(struct device *parent, | |
| 164 | +int led_classdev_register_ext(struct device *parent, | |
| 165 | 165 | struct led_classdev *led_cdev, |
| 166 | 166 | struct led_init_data *init_data); |
| 167 | 167 | |
| @@ -181,7 +181,7 @@ static inline int led_classdev_register(struct device *parent, · 13 unmodified lines | ||
| 181 | 181 | return led_classdev_register_ext(parent, led_cdev, NULL); |
| 182 | 182 | } |
| 183 | 183 | |
| 184 | −extern int devm_led_classdev_register_ext(struct device *parent, | |
| 184 | +int devm_led_classdev_register_ext(struct device *parent, | |
| 185 | 185 | struct led_classdev *led_cdev, |
| 186 | 186 | struct led_init_data *init_data); |
| 187 | 187 | |
| @@ -190,11 +190,11 @@ static inline int devm_led_classdev_register(struct device *parent, · 2 unmodified lines | ||
| 190 | 190 | { |
| 191 | 191 | return devm_led_classdev_register_ext(parent, led_cdev, NULL); |
| 192 | 192 | } |
| 193 | −extern void led_classdev_unregister(struct led_classdev *led_cdev); | |
| 194 | −extern void devm_led_classdev_unregister(struct device *parent, | |
| 195 | − struct led_classdev *led_cdev); | |
| 196 | −extern void led_classdev_suspend(struct led_classdev *led_cdev); | |
| 197 | −extern void led_classdev_resume(struct led_classdev *led_cdev); | |
| 193 | +void led_classdev_unregister(struct led_classdev *led_cdev); | |
| 194 | +void devm_led_classdev_unregister(struct device *parent, | |
| 195 | + struct led_classdev *led_cdev); | |
| 196 | +void led_classdev_suspend(struct led_classdev *led_cdev); | |
| 197 | +void led_classdev_resume(struct led_classdev *led_cdev); | |
| 198 | 198 | |
| 199 | 199 | /** |
| 200 | 200 | * led_blink_set - set blinking with software fallback |
| @@ -211,9 +211,8 @@ extern void led_classdev_resume(struct led_classdev *led_cdev); · 10 unmodified lines | ||
| 211 | 211 | * led_cdev->brightness_set() will not stop the blinking, |
| 212 | 212 | * use led_classdev_brightness_set() instead. |
| 213 | 213 | */ |
| 214 | −extern void led_blink_set(struct led_classdev *led_cdev, | |
| 215 | − unsigned long *delay_on, | |
| 216 | − unsigned long *delay_off); | |
| 214 | +void led_blink_set(struct led_classdev *led_cdev, unsigned long *delay_on, | |
| 215 | + unsigned long *delay_off); | |
| 217 | 216 | /** |
| 218 | 217 | * led_blink_set_oneshot - do a oneshot software blink |
| 219 | 218 | * @led_cdev: the LED to start blinking |
| @@ -228,10 +227,9 @@ extern void led_blink_set(struct led_classdev *led_cdev, · 8 unmodified lines | ||
| 228 | 227 | * If invert is set, led blinks for delay_off first, then for |
| 229 | 228 | * delay_on and leave the led on after the on-off cycle. |
| 230 | 229 | */ |
| 231 | −extern void led_blink_set_oneshot(struct led_classdev *led_cdev, | |
| 232 | − unsigned long *delay_on, | |
| 233 | − unsigned long *delay_off, | |
| 234 | − int invert); | |
| 230 | +void led_blink_set_oneshot(struct led_classdev *led_cdev, | |
| 231 | + unsigned long *delay_on, unsigned long *delay_off, | |
| 232 | + int invert); | |
| 235 | 233 | /** |
| 236 | 234 | * led_set_brightness - set LED brightness |
| 237 | 235 | * @led_cdev: the LED to set |
| @@ -241,8 +239,8 @@ extern void led_blink_set_oneshot(struct led_classdev *led_cdev, · 3 unmodified lines | ||
| 241 | 239 | * software blink timer that implements blinking when the |
| 242 | 240 | * hardware doesn't. This function is guaranteed not to sleep. |
| 243 | 241 | */ |
| 244 | −extern void led_set_brightness(struct led_classdev *led_cdev, | |
| 245 | − enum led_brightness brightness); | |
| 242 | +void led_set_brightness(struct led_classdev *led_cdev, | |
| 243 | + enum led_brightness brightness); | |
| 246 | 244 | |
| 247 | 245 | /** |
| 248 | 246 | * led_set_brightness_sync - set LED brightness synchronously |
| @@ -255,8 +253,8 @@ extern void led_set_brightness(struct led_classdev *led_cdev, · 6 unmodified lines | ||
| 255 | 253 | * |
| 256 | 254 | * Returns: 0 on success or negative error value on failure |
| 257 | 255 | */ |
| 258 | −extern int led_set_brightness_sync(struct led_classdev *led_cdev, | |
| 259 | − enum led_brightness value); | |
| 256 | +int led_set_brightness_sync(struct led_classdev *led_cdev, | |
| 257 | + enum led_brightness value); | |
| 260 | 258 | |
| 261 | 259 | /** |
| 262 | 260 | * led_update_brightness - update LED brightness |
| @@ -267,7 +265,7 @@ extern int led_set_brightness_sync(struct led_classdev *led_cdev, · 4 unmodified lines | ||
| 267 | 265 | * |
| 268 | 266 | * Returns: 0 on success or negative error value on failure |
| 269 | 267 | */ |
| 270 | −extern int led_update_brightness(struct led_classdev *led_cdev); | |
| 268 | +int led_update_brightness(struct led_classdev *led_cdev); | |
| 271 | 269 | |
| 272 | 270 | /** |
| 273 | 271 | * led_get_default_pattern - return default pattern |
| @@ -279,8 +277,7 @@ extern int led_update_brightness(struct led_classdev *led_cdev); · 5 unmodified lines | ||
| 279 | 277 | * Return: Allocated array of integers with default pattern from device tree |
| 280 | 278 | * or NULL. Caller is responsible for kfree(). |
| 281 | 279 | */ |
| 282 | −extern u32 *led_get_default_pattern(struct led_classdev *led_cdev, | |
| 283 | − unsigned int *size); | |
| 280 | +u32 *led_get_default_pattern(struct led_classdev *led_cdev, unsigned int *size); | |
| 284 | 281 | |
| 285 | 282 | /** |
| 286 | 283 | * led_sysfs_disable - disable LED sysfs interface |
| @@ -288,7 +285,7 @@ extern u32 *led_get_default_pattern(struct led_classdev *led_cdev, · 1 unmodified line | ||
| 288 | 285 | * |
| 289 | 286 | * Disable the led_cdev's sysfs interface. |
| 290 | 287 | */ |
| 291 | −extern void led_sysfs_disable(struct led_classdev *led_cdev); | |
| 288 | +void led_sysfs_disable(struct led_classdev *led_cdev); | |
| 292 | 289 | |
| 293 | 290 | /** |
| 294 | 291 | * led_sysfs_enable - enable LED sysfs interface |
| @@ -296,7 +293,7 @@ extern void led_sysfs_disable(struct led_classdev *led_cdev); · 1 unmodified line | ||
| 296 | 293 | * |
| 297 | 294 | * Enable the led_cdev's sysfs interface. |
| 298 | 295 | */ |
| 299 | −extern void led_sysfs_enable(struct led_classdev *led_cdev); | |
| 296 | +void led_sysfs_enable(struct led_classdev *led_cdev); | |
| 300 | 297 | |
| 301 | 298 | /** |
| 302 | 299 | * led_compose_name - compose LED class device name |
| @@ -311,8 +308,8 @@ extern void led_sysfs_enable(struct led_classdev *led_cdev); · 8 unmodified lines | ||
| 311 | 308 | * |
| 312 | 309 | * Returns: 0 on success or negative error value on failure |
| 313 | 310 | */ |
| 314 | −extern int led_compose_name(struct device *dev, struct led_init_data *init_data, | |
| 315 | − char *led_classdev_name); | |
| 311 | +int led_compose_name(struct device *dev, struct led_init_data *init_data, | |
| 312 | + char *led_classdev_name); | |
| 316 | 313 | |
| 317 | 314 | /** |
| 318 | 315 | * led_sysfs_is_disabled - check if LED sysfs interface is disabled |
| @@ -362,27 +359,24 @@ struct led_trigger { · 43 unmodified lines | ||
| 362 | 359 | #define led_trigger_get_drvdata(dev) (led_get_trigger_data(led_trigger_get_led(dev))) |
| 363 | 360 | |
| 364 | 361 | /* Registration functions for complex triggers */ |
| 365 | −extern int led_trigger_register(struct led_trigger *trigger); | |
| 366 | −extern void led_trigger_unregister(struct led_trigger *trigger); | |
| 367 | −extern int devm_led_trigger_register(struct device *dev, | |
| 362 | +int led_trigger_register(struct led_trigger *trigger); | |
| 363 | +void led_trigger_unregister(struct led_trigger *trigger); | |
| 364 | +int devm_led_trigger_register(struct device *dev, | |
| 368 | 365 | struct led_trigger *trigger); |
| 369 | 366 | |
| 370 | −extern void led_trigger_register_simple(const char *name, | |
| 367 | +void led_trigger_register_simple(const char *name, | |
| 371 | 368 | struct led_trigger **trigger); |
| 372 | −extern void led_trigger_unregister_simple(struct led_trigger *trigger); | |
| 373 | −extern void led_trigger_event(struct led_trigger *trigger, | |
| 374 | − enum led_brightness event); | |
| 375 | −extern void led_trigger_blink(struct led_trigger *trigger, | |
| 376 | − unsigned long *delay_on, | |
| 377 | − unsigned long *delay_off); | |
| 378 | −extern void led_trigger_blink_oneshot(struct led_trigger *trigger, | |
| 379 | − unsigned long *delay_on, | |
| 380 | − unsigned long *delay_off, | |
| 381 | − int invert); | |
| 382 | −extern void led_trigger_set_default(struct led_classdev *led_cdev); | |
| 383 | −extern int led_trigger_set(struct led_classdev *led_cdev, | |
| 384 | − struct led_trigger *trigger); | |
| 385 | −extern void led_trigger_remove(struct led_classdev *led_cdev); | |
| 369 | +void led_trigger_unregister_simple(struct led_trigger *trigger); | |
| 370 | +void led_trigger_event(struct led_trigger *trigger, enum led_brightness event); | |
| 371 | +void led_trigger_blink(struct led_trigger *trigger, unsigned long *delay_on, | |
| 372 | + unsigned long *delay_off); | |
| 373 | +void led_trigger_blink_oneshot(struct led_trigger *trigger, | |
| 374 | + unsigned long *delay_on, | |
| 375 | + unsigned long *delay_off, | |
| 376 | + int invert); | |
| 377 | +void led_trigger_set_default(struct led_classdev *led_cdev); | |
| 378 | +int led_trigger_set(struct led_classdev *led_cdev, struct led_trigger *trigger); | |
| 379 | +void led_trigger_remove(struct led_classdev *led_cdev); | |
| 386 | 380 | |
| 387 | 381 | static inline void led_set_trigger_data(struct led_classdev *led_cdev, |
| 388 | 382 | void *trigger_data) |
| @@ -410,8 +404,7 @@ static inline void *led_get_trigger_data(struct led_classdev *led_cdev) · 21 unmodified lines | ||
| 410 | 404 | * This is meant to be used on triggers with statically |
| 411 | 405 | * allocated name. |
| 412 | 406 | */ |
| 413 | −extern void led_trigger_rename_static(const char *name, | |
| 414 | − struct led_trigger *trig); | |
| 407 | +void led_trigger_rename_static(const char *name, struct led_trigger *trig); | |
| 415 | 408 | |
| 416 | 409 | #define module_led_trigger(__led_trigger) \ |
| 417 | 410 | module_driver(__led_trigger, led_trigger_register, \ |
| @@ -453,20 +446,20 @@ static inline void *led_get_trigger_data(struct led_classdev *led_cdev) · 35 unmodified lines | ||
| 453 | 446 | |
| 454 | 447 | /* Trigger specific functions */ |
| 455 | 448 | #ifdef CONFIG_LEDS_TRIGGER_DISK |
| 456 | −extern void ledtrig_disk_activity(bool write); | |
| 449 | +void ledtrig_disk_activity(bool write); | |
| 457 | 450 | #else |
| 458 | 451 | static inline void ledtrig_disk_activity(bool write) {} |
| 459 | 452 | #endif |
| 460 | 453 | |
| 461 | 454 | #ifdef CONFIG_LEDS_TRIGGER_MTD |
| 462 | −extern void ledtrig_mtd_activity(void); | |
| 455 | +void ledtrig_mtd_activity(void); | |
| 463 | 456 | #else |
| 464 | 457 | static inline void ledtrig_mtd_activity(void) {} |
| 465 | 458 | #endif |
| 466 | 459 | |
| 467 | 460 | #if defined(CONFIG_LEDS_TRIGGER_CAMERA) || defined(CONFIG_LEDS_TRIGGER_CAMERA_MODULE) |
| 468 | −extern void ledtrig_flash_ctrl(bool on); | |
| 469 | −extern void ledtrig_torch_ctrl(bool on); | |
| 461 | +void ledtrig_flash_ctrl(bool on); | |
| 462 | +void ledtrig_torch_ctrl(bool on); | |
| 470 | 463 | #else |
| 471 | 464 | static inline void ledtrig_flash_ctrl(bool on) {} |
| 472 | 465 | static inline void ledtrig_torch_ctrl(bool on) {} |
| @@ -546,7 +539,7 @@ enum cpu_led_event { · 73 unmodified lines | ||
| 546 | 539 | CPU_LED_HALTED, /* Machine shutdown */ |
| 547 | 540 | }; |
| 548 | 541 | #ifdef CONFIG_LEDS_TRIGGER_CPU |
| 549 | −extern void ledtrig_cpu(enum cpu_led_event evt); | |
| 542 | +void ledtrig_cpu(enum cpu_led_event evt); | |
| 550 | 543 | #else |
| 551 | 544 | static inline void ledtrig_cpu(enum cpu_led_event evt) |
| 552 | 545 | { |
| @@ -555,7 +548,7 @@ static inline void ledtrig_cpu(enum cpu_led_event evt) · 2 unmodified lines | ||
| 555 | 548 | #endif |
| 556 | 549 | |
| 557 | 550 | #ifdef CONFIG_LEDS_BRIGHTNESS_HW_CHANGED |
| 558 | −extern void led_classdev_notify_brightness_hw_changed( | |
| 551 | +void led_classdev_notify_brightness_hw_changed( | |
| 559 | 552 | struct led_classdev *led_cdev, enum led_brightness brightness); |
| 560 | 553 | #else |
| 561 | 554 | static inline void led_classdev_notify_brightness_hw_changed( |