| @@ -97,6 +97,7 @@ static struct charger_global_desc *g_desc; /* init with setup_charger_manager */ · 96 unmodified lines |
| 97 | 97 | static bool is_batt_present(struct charger_manager *cm) |
| 98 | 98 | { |
| 99 | 99 | union power_supply_propval val; |
| 100 | + struct power_supply *psy; |
| 100 | 101 | bool present = false; |
| 101 | 102 | int i, ret; |
| 102 | 103 | |
| @@ -107,16 +108,27 @@ static bool is_batt_present(struct charger_manager *cm) · 4 unmodified lines |
| 107 | 108 | case CM_NO_BATTERY: |
| 108 | 109 | break; |
| 109 | 110 | case CM_FUEL_GAUGE: |
| 110 | | − ret = cm->fuel_gauge->get_property(cm->fuel_gauge, |
| 111 | + psy = power_supply_get_by_name(cm->desc->psy_fuel_gauge); |
| 112 | + if (!psy) |
| 113 | + break; |
| 114 | + |
| 115 | + ret = psy->get_property(psy, |
| 111 | 116 | POWER_SUPPLY_PROP_PRESENT, &val); |
| 112 | 117 | if (ret == 0 && val.intval) |
| 113 | 118 | present = true; |
| 114 | 119 | break; |
| 115 | 120 | case CM_CHARGER_STAT: |
| 116 | | − for (i = 0; cm->charger_stat[i]; i++) { |
| 117 | | − ret = cm->charger_stat[i]->get_property( |
| 118 | | − cm->charger_stat[i], |
| 119 | | − POWER_SUPPLY_PROP_PRESENT, &val); |
| 121 | + for (i = 0; cm->desc->psy_charger_stat[i]; i++) { |
| 122 | + psy = power_supply_get_by_name( |
| 123 | + cm->desc->psy_charger_stat[i]); |
| 124 | + if (!psy) { |
| 125 | + dev_err(cm->dev, "Cannot find power supply \"%s\"\n", |
| 126 | + cm->desc->psy_charger_stat[i]); |
| 127 | + continue; |
| 128 | + } |
| 129 | + |
| 130 | + ret = psy->get_property(psy, POWER_SUPPLY_PROP_PRESENT, |
| 131 | + &val); |
| 120 | 132 | if (ret == 0 && val.intval) { |
| 121 | 133 | present = true; |
| 122 | 134 | break; |
| @@ -139,14 +151,20 @@ static bool is_batt_present(struct charger_manager *cm) · 16 unmodified lines |
| 139 | 151 | static bool is_ext_pwr_online(struct charger_manager *cm) |
| 140 | 152 | { |
| 141 | 153 | union power_supply_propval val; |
| 154 | + struct power_supply *psy; |
| 142 | 155 | bool online = false; |
| 143 | 156 | int i, ret; |
| 144 | 157 | |
| 145 | 158 | /* If at least one of them has one, it's yes. */ |
| 146 | | − for (i = 0; cm->charger_stat[i]; i++) { |
| 147 | | − ret = cm->charger_stat[i]->get_property( |
| 148 | | − cm->charger_stat[i], |
| 149 | | − POWER_SUPPLY_PROP_ONLINE, &val); |
| 159 | + for (i = 0; cm->desc->psy_charger_stat[i]; i++) { |
| 160 | + psy = power_supply_get_by_name(cm->desc->psy_charger_stat[i]); |
| 161 | + if (!psy) { |
| 162 | + dev_err(cm->dev, "Cannot find power supply \"%s\"\n", |
| 163 | + cm->desc->psy_charger_stat[i]); |
| 164 | + continue; |
| 165 | + } |
| 166 | + |
| 167 | + ret = psy->get_property(psy, POWER_SUPPLY_PROP_ONLINE, &val); |
| 150 | 168 | if (ret == 0 && val.intval) { |
| 151 | 169 | online = true; |
| 152 | 170 | break; |
| @@ -167,12 +185,14 @@ static bool is_ext_pwr_online(struct charger_manager *cm) · 14 unmodified lines |
| 167 | 185 | static int get_batt_uV(struct charger_manager *cm, int *uV) |
| 168 | 186 | { |
| 169 | 187 | union power_supply_propval val; |
| 188 | + struct power_supply *fuel_gauge; |
| 170 | 189 | int ret; |
| 171 | 190 | |
| 172 | | − if (!cm->fuel_gauge) |
| 191 | + fuel_gauge = power_supply_get_by_name(cm->desc->psy_fuel_gauge); |
| 192 | + if (!fuel_gauge) |
| 173 | 193 | return -ENODEV; |
| 174 | 194 | |
| 175 | | − ret = cm->fuel_gauge->get_property(cm->fuel_gauge, |
| 195 | + ret = fuel_gauge->get_property(fuel_gauge, |
| 176 | 196 | POWER_SUPPLY_PROP_VOLTAGE_NOW, &val); |
| 177 | 197 | if (ret) |
| 178 | 198 | return ret; |
| @@ -189,6 +209,7 @@ static bool is_charging(struct charger_manager *cm) · 10 unmodified lines |
| 189 | 209 | { |
| 190 | 210 | int i, ret; |
| 191 | 211 | bool charging = false; |
| 212 | + struct power_supply *psy; |
| 192 | 213 | union power_supply_propval val; |
| 193 | 214 | |
| 194 | 215 | /* If there is no battery, it cannot be charged */ |
| @@ -196,17 +217,22 @@ static bool is_charging(struct charger_manager *cm) · 1 unmodified line |
| 196 | 217 | return false; |
| 197 | 218 | |
| 198 | 219 | /* If at least one of the charger is charging, return yes */ |
| 199 | | − for (i = 0; cm->charger_stat[i]; i++) { |
| 220 | + for (i = 0; cm->desc->psy_charger_stat[i]; i++) { |
| 200 | 221 | /* 1. The charger sholuld not be DISABLED */ |
| 201 | 222 | if (cm->emergency_stop) |
| 202 | 223 | continue; |
| 203 | 224 | if (!cm->charger_enabled) |
| 204 | 225 | continue; |
| 205 | 226 | |
| 227 | + psy = power_supply_get_by_name(cm->desc->psy_charger_stat[i]); |
| 228 | + if (!psy) { |
| 229 | + dev_err(cm->dev, "Cannot find power supply \"%s\"\n", |
| 230 | + cm->desc->psy_charger_stat[i]); |
| 231 | + continue; |
| 232 | + } |
| 233 | + |
| 206 | 234 | /* 2. The charger should be online (ext-power) */ |
| 207 | | − ret = cm->charger_stat[i]->get_property( |
| 208 | | − cm->charger_stat[i], |
| 209 | | − POWER_SUPPLY_PROP_ONLINE, &val); |
| 235 | + ret = psy->get_property(psy, POWER_SUPPLY_PROP_ONLINE, &val); |
| 210 | 236 | if (ret) { |
| 211 | 237 | dev_warn(cm->dev, "Cannot read ONLINE value from %s\n", |
| 212 | 238 | cm->desc->psy_charger_stat[i]); |
| @@ -219,9 +245,7 @@ static bool is_charging(struct charger_manager *cm) · 6 unmodified lines |
| 219 | 245 | * 3. The charger should not be FULL, DISCHARGING, |
| 220 | 246 | * or NOT_CHARGING. |
| 221 | 247 | */ |
| 222 | | − ret = cm->charger_stat[i]->get_property( |
| 223 | | − cm->charger_stat[i], |
| 224 | | − POWER_SUPPLY_PROP_STATUS, &val); |
| 248 | + ret = psy->get_property(psy, POWER_SUPPLY_PROP_STATUS, &val); |
| 225 | 249 | if (ret) { |
| 226 | 250 | dev_warn(cm->dev, "Cannot read STATUS value from %s\n", |
| 227 | 251 | cm->desc->psy_charger_stat[i]); |
| @@ -248,6 +272,7 @@ static bool is_full_charged(struct charger_manager *cm) · 20 unmodified lines |
| 248 | 272 | { |
| 249 | 273 | struct charger_desc *desc = cm->desc; |
| 250 | 274 | union power_supply_propval val; |
| 275 | + struct power_supply *fuel_gauge; |
| 251 | 276 | int ret = 0; |
| 252 | 277 | int uV; |
| 253 | 278 | |
| @@ -255,11 +280,15 @@ static bool is_full_charged(struct charger_manager *cm) · 1 unmodified line |
| 255 | 280 | if (!is_batt_present(cm)) |
| 256 | 281 | return false; |
| 257 | 282 | |
| 258 | | − if (cm->fuel_gauge && desc->fullbatt_full_capacity > 0) { |
| 283 | + fuel_gauge = power_supply_get_by_name(cm->desc->psy_fuel_gauge); |
| 284 | + if (!fuel_gauge) |
| 285 | + return false; |
| 286 | + |
| 287 | + if (desc->fullbatt_full_capacity > 0) { |
| 259 | 288 | val.intval = 0; |
| 260 | 289 | |
| 261 | 290 | /* Not full if capacity of fuel gauge isn't full */ |
| 262 | | − ret = cm->fuel_gauge->get_property(cm->fuel_gauge, |
| 291 | + ret = fuel_gauge->get_property(fuel_gauge, |
| 263 | 292 | POWER_SUPPLY_PROP_CHARGE_FULL, &val); |
| 264 | 293 | if (!ret && val.intval > desc->fullbatt_full_capacity) |
| 265 | 294 | return true; |
| @@ -273,10 +302,10 @@ static bool is_full_charged(struct charger_manager *cm) · 7 unmodified lines |
| 273 | 302 | } |
| 274 | 303 | |
| 275 | 304 | /* Full, if the capacity is more than fullbatt_soc */ |
| 276 | | − if (cm->fuel_gauge && desc->fullbatt_soc > 0) { |
| 305 | + if (desc->fullbatt_soc > 0) { |
| 277 | 306 | val.intval = 0; |
| 278 | 307 | |
| 279 | | − ret = cm->fuel_gauge->get_property(cm->fuel_gauge, |
| 308 | + ret = fuel_gauge->get_property(fuel_gauge, |
| 280 | 309 | POWER_SUPPLY_PROP_CAPACITY, &val); |
| 281 | 310 | if (!ret && val.intval >= desc->fullbatt_soc) |
| 282 | 311 | return true; |
| @@ -551,6 +580,20 @@ static int check_charging_duration(struct charger_manager *cm) · 268 unmodified lines |
| 551 | 580 | return ret; |
| 552 | 581 | } |
| 553 | 582 | |
| 583 | +static int cm_get_battery_temperature_by_psy(struct charger_manager *cm, |
| 584 | + int *temp) |
| 585 | +{ |
| 586 | + struct power_supply *fuel_gauge; |
| 587 | + |
| 588 | + fuel_gauge = power_supply_get_by_name(cm->desc->psy_fuel_gauge); |
| 589 | + if (!fuel_gauge) |
| 590 | + return -ENODEV; |
| 591 | + |
| 592 | + return fuel_gauge->get_property(fuel_gauge, |
| 593 | + POWER_SUPPLY_PROP_TEMP, |
| 594 | + (union power_supply_propval *)temp); |
| 595 | +} |
| 596 | + |
| 554 | 597 | static int cm_get_battery_temperature(struct charger_manager *cm, |
| 555 | 598 | int *temp) |
| 556 | 599 | { |
| @@ -560,15 +603,18 @@ static int cm_get_battery_temperature(struct charger_manager *cm, · 3 unmodified lines |
| 560 | 603 | return -ENODEV; |
| 561 | 604 | |
| 562 | 605 | #ifdef CONFIG_THERMAL |
| 563 | | − ret = thermal_zone_get_temp(cm->tzd_batt, (unsigned long *)temp); |
| 564 | | − if (!ret) |
| 565 | | − /* Calibrate temperature unit */ |
| 566 | | − *temp /= 100; |
| 567 | | −#else |
| 568 | | − ret = cm->fuel_gauge->get_property(cm->fuel_gauge, |
| 569 | | − POWER_SUPPLY_PROP_TEMP, |
| 570 | | − (union power_supply_propval *)temp); |
| 606 | + if (cm->tzd_batt) { |
| 607 | + ret = thermal_zone_get_temp(cm->tzd_batt, (unsigned long *)temp); |
| 608 | + if (!ret) |
| 609 | + /* Calibrate temperature unit */ |
| 610 | + *temp /= 100; |
| 611 | + } else |
| 571 | 612 | #endif |
| 613 | + { |
| 614 | + /* if-else continued from CONFIG_THERMAL */ |
| 615 | + ret = cm_get_battery_temperature_by_psy(cm, temp); |
| 616 | + } |
| 617 | + |
| 572 | 618 | return ret; |
| 573 | 619 | } |
| 574 | 620 | |
| @@ -827,6 +873,7 @@ static int charger_get_property(struct power_supply *psy, · 252 unmodified lines |
| 827 | 873 | struct charger_manager *cm = container_of(psy, |
| 828 | 874 | struct charger_manager, charger_psy); |
| 829 | 875 | struct charger_desc *desc = cm->desc; |
| 876 | + struct power_supply *fuel_gauge; |
| 830 | 877 | int ret = 0; |
| 831 | 878 | int uV; |
| 832 | 879 | |
| @@ -857,14 +904,20 @@ static int charger_get_property(struct power_supply *psy, · 24 unmodified lines |
| 857 | 904 | ret = get_batt_uV(cm, &val->intval); |
| 858 | 905 | break; |
| 859 | 906 | case POWER_SUPPLY_PROP_CURRENT_NOW: |
| 860 | | − ret = cm->fuel_gauge->get_property(cm->fuel_gauge, |
| 907 | + fuel_gauge = power_supply_get_by_name(cm->desc->psy_fuel_gauge); |
| 908 | + if (!fuel_gauge) { |
| 909 | + ret = -ENODEV; |
| 910 | + break; |
| 911 | + } |
| 912 | + ret = fuel_gauge->get_property(fuel_gauge, |
| 861 | 913 | POWER_SUPPLY_PROP_CURRENT_NOW, val); |
| 862 | 914 | break; |
| 863 | 915 | case POWER_SUPPLY_PROP_TEMP: |
| 864 | 916 | case POWER_SUPPLY_PROP_TEMP_AMBIENT: |
| 865 | 917 | return cm_get_battery_temperature(cm, &val->intval); |
| 866 | 918 | case POWER_SUPPLY_PROP_CAPACITY: |
| 867 | | − if (!cm->fuel_gauge) { |
| 919 | + fuel_gauge = power_supply_get_by_name(cm->desc->psy_fuel_gauge); |
| 920 | + if (!fuel_gauge) { |
| 868 | 921 | ret = -ENODEV; |
| 869 | 922 | break; |
| 870 | 923 | } |
| @@ -875,7 +928,7 @@ static int charger_get_property(struct power_supply *psy, · 4 unmodified lines |
| 875 | 928 | break; |
| 876 | 929 | } |
| 877 | 930 | |
| 878 | | − ret = cm->fuel_gauge->get_property(cm->fuel_gauge, |
| 931 | + ret = fuel_gauge->get_property(fuel_gauge, |
| 879 | 932 | POWER_SUPPLY_PROP_CAPACITY, val); |
| 880 | 933 | if (ret) |
| 881 | 934 | break; |
| @@ -924,7 +977,14 @@ static int charger_get_property(struct power_supply *psy, · 42 unmodified lines |
| 924 | 977 | break; |
| 925 | 978 | case POWER_SUPPLY_PROP_CHARGE_NOW: |
| 926 | 979 | if (is_charging(cm)) { |
| 927 | | − ret = cm->fuel_gauge->get_property(cm->fuel_gauge, |
| 980 | + fuel_gauge = power_supply_get_by_name( |
| 981 | + cm->desc->psy_fuel_gauge); |
| 982 | + if (!fuel_gauge) { |
| 983 | + ret = -ENODEV; |
| 984 | + break; |
| 985 | + } |
| 986 | + |
| 987 | + ret = fuel_gauge->get_property(fuel_gauge, |
| 928 | 988 | POWER_SUPPLY_PROP_CHARGE_NOW, |
| 929 | 989 | val); |
| 930 | 990 | if (ret) { |
| @@ -970,6 +1030,7 @@ static struct power_supply psy_default = { · 39 unmodified lines |
| 970 | 1030 | .properties = default_charger_props, |
| 971 | 1031 | .num_properties = ARRAY_SIZE(default_charger_props), |
| 972 | 1032 | .get_property = charger_get_property, |
| 1033 | + .no_thermal = true, |
| 973 | 1034 | }; |
| 974 | 1035 | |
| 975 | 1036 | /** |
| @@ -1485,14 +1546,15 @@ err: · 509 unmodified lines |
| 1485 | 1546 | return ret; |
| 1486 | 1547 | } |
| 1487 | 1548 | |
| 1488 | | −static int cm_init_thermal_data(struct charger_manager *cm) |
| 1549 | +static int cm_init_thermal_data(struct charger_manager *cm, |
| 1550 | + struct power_supply *fuel_gauge) |
| 1489 | 1551 | { |
| 1490 | 1552 | struct charger_desc *desc = cm->desc; |
| 1491 | 1553 | union power_supply_propval val; |
| 1492 | 1554 | int ret; |
| 1493 | 1555 | |
| 1494 | 1556 | /* Verify whether fuel gauge provides battery temperature */ |
| 1495 | | − ret = cm->fuel_gauge->get_property(cm->fuel_gauge, |
| 1557 | + ret = fuel_gauge->get_property(fuel_gauge, |
| 1496 | 1558 | POWER_SUPPLY_PROP_TEMP, &val); |
| 1497 | 1559 | |
| 1498 | 1560 | if (!ret) { |
| @@ -1502,8 +1564,6 @@ static int cm_init_thermal_data(struct charger_manager *cm) · 3 unmodified lines |
| 1502 | 1564 | cm->desc->measure_battery_temp = true; |
| 1503 | 1565 | } |
| 1504 | 1566 | #ifdef CONFIG_THERMAL |
| 1505 | | − cm->tzd_batt = cm->fuel_gauge->tzd; |
| 1506 | | − |
| 1507 | 1567 | if (ret && desc->thermal_zone) { |
| 1508 | 1568 | cm->tzd_batt = |
| 1509 | 1569 | thermal_zone_get_zone_by_name(desc->thermal_zone); |
| @@ -1666,6 +1726,7 @@ static int charger_manager_probe(struct platform_device *pdev) · 156 unmodified lines |
| 1666 | 1726 | int ret = 0, i = 0; |
| 1667 | 1727 | int j = 0; |
| 1668 | 1728 | union power_supply_propval val; |
| 1729 | + struct power_supply *fuel_gauge; |
| 1669 | 1730 | |
| 1670 | 1731 | if (g_desc && !rtc_dev && g_desc->rtc_name) { |
| 1671 | 1732 | rtc_dev = rtc_class_open(g_desc->rtc_name); |
| @@ -1729,23 +1790,20 @@ static int charger_manager_probe(struct platform_device *pdev) · 57 unmodified lines |
| 1729 | 1790 | while (desc->psy_charger_stat[i]) |
| 1730 | 1791 | i++; |
| 1731 | 1792 | |
| 1732 | | − cm->charger_stat = devm_kzalloc(&pdev->dev, |
| 1733 | | − sizeof(struct power_supply *) * i, GFP_KERNEL); |
| 1734 | | − if (!cm->charger_stat) |
| 1735 | | − return -ENOMEM; |
| 1736 | | − |
| 1793 | + /* Check if charger's supplies are present at probe */ |
| 1737 | 1794 | for (i = 0; desc->psy_charger_stat[i]; i++) { |
| 1738 | | − cm->charger_stat[i] = power_supply_get_by_name( |
| 1739 | | − desc->psy_charger_stat[i]); |
| 1740 | | − if (!cm->charger_stat[i]) { |
| 1795 | + struct power_supply *psy; |
| 1796 | + |
| 1797 | + psy = power_supply_get_by_name(desc->psy_charger_stat[i]); |
| 1798 | + if (!psy) { |
| 1741 | 1799 | dev_err(&pdev->dev, "Cannot find power supply \"%s\"\n", |
| 1742 | 1800 | desc->psy_charger_stat[i]); |
| 1743 | 1801 | return -ENODEV; |
| 1744 | 1802 | } |
| 1745 | 1803 | } |
| 1746 | 1804 | |
| 1747 | | − cm->fuel_gauge = power_supply_get_by_name(desc->psy_fuel_gauge); |
| 1748 | | − if (!cm->fuel_gauge) { |
| 1805 | + fuel_gauge = power_supply_get_by_name(desc->psy_fuel_gauge); |
| 1806 | + if (!fuel_gauge) { |
| 1749 | 1807 | dev_err(&pdev->dev, "Cannot find power supply \"%s\"\n", |
| 1750 | 1808 | desc->psy_fuel_gauge); |
| 1751 | 1809 | return -ENODEV; |
| @@ -1788,13 +1846,13 @@ static int charger_manager_probe(struct platform_device *pdev) · 36 unmodified lines |
| 1788 | 1846 | cm->charger_psy.num_properties = psy_default.num_properties; |
| 1789 | 1847 | |
| 1790 | 1848 | /* Find which optional psy-properties are available */ |
| 1791 | | − if (!cm->fuel_gauge->get_property(cm->fuel_gauge, |
| 1849 | + if (!fuel_gauge->get_property(fuel_gauge, |
| 1792 | 1850 | POWER_SUPPLY_PROP_CHARGE_NOW, &val)) { |
| 1793 | 1851 | cm->charger_psy.properties[cm->charger_psy.num_properties] = |
| 1794 | 1852 | POWER_SUPPLY_PROP_CHARGE_NOW; |
| 1795 | 1853 | cm->charger_psy.num_properties++; |
| 1796 | 1854 | } |
| 1797 | | − if (!cm->fuel_gauge->get_property(cm->fuel_gauge, |
| 1855 | + if (!fuel_gauge->get_property(fuel_gauge, |
| 1798 | 1856 | POWER_SUPPLY_PROP_CURRENT_NOW, |
| 1799 | 1857 | &val)) { |
| 1800 | 1858 | cm->charger_psy.properties[cm->charger_psy.num_properties] = |
| @@ -1802,7 +1860,7 @@ static int charger_manager_probe(struct platform_device *pdev) · 1 unmodified line |
| 1802 | 1860 | cm->charger_psy.num_properties++; |
| 1803 | 1861 | } |
| 1804 | 1862 | |
| 1805 | | − ret = cm_init_thermal_data(cm); |
| 1863 | + ret = cm_init_thermal_data(cm, fuel_gauge); |
| 1806 | 1864 | if (ret) { |
| 1807 | 1865 | dev_err(&pdev->dev, "Failed to initialize thermal data\n"); |
| 1808 | 1866 | cm->desc->measure_battery_temp = false; |
| @@ -2066,8 +2124,8 @@ static bool find_power_supply(struct charger_manager *cm, · 257 unmodified lines |
| 2066 | 2124 | int i; |
| 2067 | 2125 | bool found = false; |
| 2068 | 2126 | |
| 2069 | | − for (i = 0; cm->charger_stat[i]; i++) { |
| 2070 | | − if (psy == cm->charger_stat[i]) { |
| 2127 | + for (i = 0; cm->desc->psy_charger_stat[i]; i++) { |
| 2128 | + if (!strcmp(psy->name, cm->desc->psy_charger_stat[i])) { |
| 2071 | 2129 | found = true; |
| 2072 | 2130 | break; |
| 2073 | 2131 | } |