The entire way how cros sysfs attibutes are created is broken. cros_ec_lightbar should be its own driver and its attributes should be associated with a lightbar driver not the mfd driver. In order to retain the path, the lightbar attributes are attached to the cros_class. The patch also adds the sysfs documentation.
Showing the changes to include/linux (1 of 7 files). Show all
Unified · Split
| @@ -327,7 +327,6 @@ u32 cros_ec_get_host_event(struct cros_ec_device *ec_dev); · 326 unmodified lines | ||
| 327 | 327 | |
| 328 | 328 | /* sysfs stuff */ |
| 329 | 329 | extern struct attribute_group cros_ec_attr_group; |
| 330 | −extern struct attribute_group cros_ec_lightbar_attr_group; | |
| 331 | 330 | extern struct attribute_group cros_ec_vbc_attr_group; |
| 332 | 331 | |
| 333 | 332 | /* debugfs stuff */ |