tracing_read_pipe zeros all fields bellow "seq". The declaration contains a comment about that, but it doesn't help. The first field is "snapshot", it's true when current open file is snapshot. Looks obvious, that it should not be zeroed. The second field is "started". It was converted from cpumask_t to cpumask_var_t (v2.6.28-4983-g4462344), in other words it was converted from cpumask to pointer on cpumask. Currently the reference on "started" memory is lost after the first read from tracing_read_pipe and a proper object will never be freed. The "started" is never dereferenced for trace_pipe, because trace_pipe can't have the TRACE_FILE_ANNOTATE options. Link: http://lkml.kernel.org/r/1375463803-3085183-1-git-send-email-avagin@openvz.org
Unified · Split
| @@ -78,6 +78,11 @@ struct trace_iterator { · 77 unmodified lines | ||
| 78 | 78 | /* trace_seq for __print_flags() and __print_symbolic() etc. */ |
| 79 | 79 | struct trace_seq tmp_seq; |
| 80 | 80 | |
| 81 | + cpumask_var_t started; | |
| 82 | + | |
| 83 | + /* it's true when current open file is snapshot */ | |
| 84 | + bool snapshot; | |
| 85 | + | |
| 81 | 86 | /* The below is zeroed out in pipe_read */ |
| 82 | 87 | struct trace_seq seq; |
| 83 | 88 | struct trace_entry *ent; |
| @@ -90,10 +95,7 @@ struct trace_iterator { · 6 unmodified lines | ||
| 90 | 95 | loff_t pos; |
| 91 | 96 | long idx; |
| 92 | 97 | |
| 93 | − cpumask_var_t started; | |
| 94 | − | |
| 95 | − /* it's true when current open file is snapshot */ | |
| 96 | − bool snapshot; | |
| 98 | + /* All new field here will be zeroed out in pipe_read */ | |
| 97 | 99 | }; |
| 98 | 100 | |
| 99 | 101 | enum trace_iter_flags { |
| @@ -4151,6 +4151,7 @@ waitagain: · 4150 unmodified lines | ||
| 4151 | 4151 | memset(&iter->seq, 0, |
| 4152 | 4152 | sizeof(struct trace_iterator) - |
| 4153 | 4153 | offsetof(struct trace_iterator, seq)); |
| 4154 | + cpumask_clear(iter->started); | |
| 4154 | 4155 | iter->pos = -1; |
| 4155 | 4156 | |
| 4156 | 4157 | trace_event_read_lock(); |