History

MIPS: KVM: Do not sign extend on unsigned MMIO load

Fix possible unintended sign extension in unsigned MMIO loads by casting to uint16_t in the case of mmio_needed != 2.

Nicholas Mc Guire committed 11 years ago

Commit ed9244e1 parent 8833bc31 file · +1 −1Browse files

Unified · Split

arch/mips/kvm/emulate.c+1−1
@@ -2409,7 +2409,7 @@ enum emulation_result kvm_mips_complete_mmio_load(struct kvm_vcpu *vcpu, · 2408 unmodified lines
2409 if (vcpu->mmio_needed == 2)2409 if (vcpu->mmio_needed == 2)
2410 *gpr = *(int16_t *) run->mmio.data;2410 *gpr = *(int16_t *) run->mmio.data;
2411 else2411 else
2412 *gpr = *(int16_t *) run->mmio.data;2412 *gpr = *(uint16_t *)run->mmio.data;
2413 2413
2414 break;2414 break;
2415 case 1:2415 case 1:

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t