Commit 096335b3f983 ("mlx4_core: Allow dynamic MTU configuration for IB ports") modifies the port VL setting. This exposes a bug in mlx4_common_set_port(), where the VL cap value passed in (inside the command mailbox) is incorrectly zeroed-out: mlx4_SET_PORT modifies the VL_cap field (byte 3 of the mailbox). Since the SET_PORT command is paravirtualized on the master as well as on the slaves, mlx4_SET_PORT_wrapper() is invoked on the master. This calls mlx4_common_set_port() where mailbox byte 3 gets overwritten by code which should only set a single bit in that byte (for the reset qkey counter flag) -- but instead overwrites the entire byte. The result is that when running in SR-IOV mode, the VL_cap will be set to zero -- fix this.
Unified · Split
| @@ -697,10 +697,10 @@ static int mlx4_common_set_port(struct mlx4_dev *dev, int slave, u32 in_mod, · 696 unmodified lines | ||
| 697 | 697 | if (slave != dev->caps.function) |
| 698 | 698 | memset(inbox->buf, 0, 256); |
| 699 | 699 | if (dev->flags & MLX4_FLAG_OLD_PORT_CMDS) { |
| 700 | − *(u8 *) inbox->buf = !!reset_qkey_viols << 6; | |
| 700 | + *(u8 *) inbox->buf |= !!reset_qkey_viols << 6; | |
| 701 | 701 | ((__be32 *) inbox->buf)[2] = agg_cap_mask; |
| 702 | 702 | } else { |
| 703 | − ((u8 *) inbox->buf)[3] = !!reset_qkey_viols; | |
| 703 | + ((u8 *) inbox->buf)[3] |= !!reset_qkey_viols; | |
| 704 | 704 | ((__be32 *) inbox->buf)[1] = agg_cap_mask; |
| 705 | 705 | } |
| 706 | 706 | |