History

eventfs: Free all of the eventfs_inode after RCU

The freeing of eventfs_inode via a kfree_rcu() callback. But the content of the eventfs_inode was being freed after the last kref. This is dangerous, as changes are being made that can access the content of an eventfs_inode from an RCU loop. Instead of using kfree_rcu() use call_rcu() that calls a function to do all the freeing of the eventfs_inode after a RCU grace period has expired. Link: https://lore.kernel.org/linux-trace-kernel/20240502200905.370261163@goodmis.org

Steven Rostedt (Google) committed 2 years ago

Commit ee4e0371 parent b63db581 file · +16 −9Browse files

Unified · Split

fs/tracefs/event_inode.c+16−9
@@ -73,6 +73,21 @@ enum { · 72 unmodified lines
7373
7474 #define EVENTFS_MODE_MASK (EVENTFS_SAVE_MODE - 1)
7575
76+static void free_ei_rcu(struct rcu_head *rcu)
77+{
78+ struct eventfs_inode *ei = container_of(rcu, struct eventfs_inode, rcu);
79+ struct eventfs_root_inode *rei;
80+
81+ kfree(ei->entry_attrs);
82+ kfree_const(ei->name);
83+ if (ei->is_events) {
84+ rei = get_root_inode(ei);
85+ kfree(rei);
86+ } else {
87+ kfree(ei);
88+ }
89+}
90+
7691 /*
7792 * eventfs_inode reference count management.
7893 *
@@ -85,7 +100,6 @@ static void release_ei(struct kref *ref) · 6 unmodified lines
85100 {
86101 struct eventfs_inode *ei = container_of(ref, struct eventfs_inode, kref);
87102 const struct eventfs_entry *entry;
88− struct eventfs_root_inode *rei;
89103
90104 WARN_ON_ONCE(!ei->is_freed);
91105
@@ -95,14 +109,7 @@ static void release_ei(struct kref *ref) · 3 unmodified lines
95109 entry->release(entry->name, ei->data);
96110 }
97111
98− kfree(ei->entry_attrs);
99− kfree_const(ei->name);
100− if (ei->is_events) {
101− rei = get_root_inode(ei);
102− kfree_rcu(rei, ei.rcu);
103− } else {
104− kfree_rcu(ei, rcu);
105− }
112+ call_rcu(&ei->rcu, free_ei_rcu);
106113 }
107114
108115 static inline void put_ei(struct eventfs_inode *ei)

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t