History

Merge tag 'pm-5.0' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm

Pull power management fixes from Rafael Wysocki: "These fix a regression in the PM-runtime framework introduced by the recent switch-over of it to using hrtimers and a use-after-free introduced by one of the recent changes in the scmi-cpufreq driver. Specifics: - Use hrtimer_try_to_cancel() instead of hrtimer_cancel() in the PM-runtime framework to avoid a possible timer-related deadlock introduced recently (Vincent Guittot). - Reorder the scmi-cpufreq driver code to avoid accessing memory that has just been freed (Yangtao Li)" * tag 'pm-5.0' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm: PM-runtime: Fix deadlock when canceling hrtimer cpufreq: scmi: Fix use-after-free in scmi_cpufreq_exit()

Linus Torvalds committed 7 years ago

Commit ef4edb32 parents 9053d2d 5b317cb2 files · +2 −2Browse files

Unified · Split

2 files
  1. drivers/base/power/runtime.c +1 −1
  2. drivers/cpufreq/scmi-cpufreq.c +1 −1
drivers/base/power/runtime.c+1−1
@@ -95,7 +95,7 @@ static void __update_runtime_status(struct device *dev, enum rpm_status status) · 94 unmodified lines
9595 static void pm_runtime_deactivate_timer(struct device *dev)
9696 {
9797 if (dev->power.timer_expires > 0) {
98− hrtimer_cancel(&dev->power.suspend_timer);
98+ hrtimer_try_to_cancel(&dev->power.suspend_timer);
9999 dev->power.timer_expires = 0;
100100 }
101101 }
drivers/cpufreq/scmi-cpufreq.c+1−1
@@ -187,8 +187,8 @@ static int scmi_cpufreq_exit(struct cpufreq_policy *policy) · 186 unmodified lines
187187
188188 cpufreq_cooling_unregister(priv->cdev);
189189 dev_pm_opp_free_cpufreq_table(priv->cpu_dev, &policy->freq_table);
190− kfree(priv);
191190 dev_pm_opp_remove_all_dynamic(priv->cpu_dev);
191+ kfree(priv);
192192
193193 return 0;
194194 }