History

tracing: Use seq_buf_hex_dump() to dump buffers

Without this, buffers can be printed with __print_array macro that has no formatting options and can be hard to read. The other way is to mimic formatting capability with multiple calls of trace event with one call per row which gives performance impact and different timestamp in each row. Link: http://lkml.kernel.org/r/1573130738-29390-2-git-send-email-piotrx.maziarz@linux.intel.com

Piotr Maziarz committed 7 years ago

Commit ef56e041 parent 353cade5 files · +60 −0Browse files

Showing the changes to include/linux (2 of 5 files). Show all

Unified · Split

2 files
  1. include/linux/trace_events.h +5 −0
  2. include/linux/trace_seq.h +4 −0
include/linux/trace_events.h+5−0
@@ -45,6 +45,11 @@ const char *trace_print_array_seq(struct trace_seq *p, · 44 unmodified lines
45 const void *buf, int count,45 const void *buf, int count,
46 size_t el_size);46 size_t el_size);
47 47
48const char *
49trace_print_hex_dump_seq(struct trace_seq *p, const char *prefix_str,
50 int prefix_type, int rowsize, int groupsize,
51 const void *buf, size_t len, bool ascii);
52
48struct trace_iterator;53struct trace_iterator;
49struct trace_event;54struct trace_event;
50 55
include/linux/trace_seq.h+4−0
@@ -92,6 +92,10 @@ extern int trace_seq_path(struct trace_seq *s, const struct path *path); · 91 unmodified lines
92extern void trace_seq_bitmask(struct trace_seq *s, const unsigned long *maskp,92extern void trace_seq_bitmask(struct trace_seq *s, const unsigned long *maskp,
93 int nmaskbits);93 int nmaskbits);
94 94
95extern int trace_seq_hex_dump(struct trace_seq *s, const char *prefix_str,
96 int prefix_type, int rowsize, int groupsize,
97 const void *buf, size_t len, bool ascii);
98
95#else /* CONFIG_TRACING */99#else /* CONFIG_TRACING */
96static inline void trace_seq_printf(struct trace_seq *s, const char *fmt, ...)100static inline void trace_seq_printf(struct trace_seq *s, const char *fmt, ...)
97{101{

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t