Commit 412e6037324 ("spi: core: avoid waking pump thread from spi_sync instead run teardown delayed") introduced regressions on some boards, apparently connected to spi_mem not triggering shutdown properly any more. Since we've thus far been unable to figure out exactly where the breakage is revert the optimisation for now.
Showing the changes to include/linux (1 of 2 files). Show all
Unified · Split
| @@ -334,7 +334,6 @@ static inline void spi_unregister_driver(struct spi_driver *sdrv) · 333 unmodified lines | |||
| 334 | * @kworker: thread struct for message pump | 334 | * @kworker: thread struct for message pump |
| 335 | * @kworker_task: pointer to task for message pump kworker thread | 335 | * @kworker_task: pointer to task for message pump kworker thread |
| 336 | * @pump_messages: work struct for scheduling work to the message pump | 336 | * @pump_messages: work struct for scheduling work to the message pump |
| 337 | * @pump_idle_teardown: work structure for scheduling a teardown delayed | ||
| 338 | * @queue_lock: spinlock to syncronise access to message queue | 337 | * @queue_lock: spinlock to syncronise access to message queue |
| 339 | * @queue: message queue | 338 | * @queue: message queue |
| 340 | * @idling: the device is entering idle state | 339 | * @idling: the device is entering idle state |
| @@ -533,7 +532,6 @@ struct spi_controller { · 192 unmodified lines | |||
| 533 | struct kthread_worker kworker; | 532 | struct kthread_worker kworker; |
| 534 | struct task_struct *kworker_task; | 533 | struct task_struct *kworker_task; |
| 535 | struct kthread_work pump_messages; | 534 | struct kthread_work pump_messages; |
| 536 | struct kthread_delayed_work pump_idle_teardown; | ||
| 537 | spinlock_t queue_lock; | 535 | spinlock_t queue_lock; |
| 538 | struct list_head queue; | 536 | struct list_head queue; |
| 539 | struct spi_message *cur_msg; | 537 | struct spi_message *cur_msg; |