Commit fd0a109a0f6b ("net, pidfs: prepare for handing out pidfds for reaped sk->sk_peer_pid") inserted a prepare_peercred() call between err = -EINVAL and the socket-state check in unix_listen(). Since prepare_peercred() leaves err at 0 on success, listen() on an AF_UNIX socket that is not in TCP_CLOSE or TCP_LISTEN state (e.g. one that is already connected) now silently returns success without doing anything, instead of failing with EINVAL as it did before.
Unified · Split
| @@ -823,6 +823,7 @@ static int unix_listen(struct socket *sock, int backlog) · 822 unmodified lines | |||
| 823 | if (err) | 823 | if (err) |
| 824 | goto out; | 824 | goto out; |
| 825 | unix_state_lock(sk); | 825 | unix_state_lock(sk); |
| 826 | err = -EINVAL; | ||
| 826 | if (sk->sk_state != TCP_CLOSE && sk->sk_state != TCP_LISTEN) | 827 | if (sk->sk_state != TCP_CLOSE && sk->sk_state != TCP_LISTEN) |
| 827 | goto out_unlock; | 828 | goto out_unlock; |
| 828 | if (backlog > sk->sk_max_ack_backlog) | 829 | if (backlog > sk->sk_max_ack_backlog) |