History

virtio_ccw: future-proof finalize_features

We never negotiate revision > 1, but just to make this code more likely to work when we do, require VERSION_1 with any revision >= 1.

Michael S. Tsirkin committed 11 years ago

Commit f13d8bc1 parent 5f4c9761 file · +1 −1Browse files

Unified · Split

drivers/s390/kvm/virtio_ccw.c+1−1
@@ -758,7 +758,7 @@ static int virtio_ccw_finalize_features(struct virtio_device *vdev) · 757 unmodified lines
758758 struct virtio_feature_desc *features;
759759 struct ccw1 *ccw;
760760
761− if (vcdev->revision == 1 &&
761+ if (vcdev->revision >= 1 &&
762762 !__virtio_test_bit(vdev, VIRTIO_F_VERSION_1)) {
763763 dev_err(&vdev->dev, "virtio: device uses revision 1 "
764764 "but does not have VIRTIO_F_VERSION_1\n");

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t