History

perf scripts python: exported-sql-viewer.py: Fix time chart call tree

Using Python version 3.8.2 and PySide2 version 5.14.0, time chart call tree would not expand the tree to the result. Fix by using setExpanded(). Example: $ perf record -e intel_pt//u uname Linux [ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.034 MB perf.data ] $ perf script --itrace=bep -s ~/libexec/perf-core/scripts/python/export-to-sqlite.py perf.data.db branches calls 2020-06-26 15:32:14.928997 Creating database ... 2020-06-26 15:32:14.933971 Writing records... 2020-06-26 15:32:15.535251 Adding indexes 2020-06-26 15:32:15.542993 Dropping unused tables 2020-06-26 15:32:15.549716 Done $ python3 ~/libexec/perf-core/scripts/python/exported-sql-viewer.py perf.data.db Select: Charts -> Time chart by CPU Move mouse over middle of chart Right-click and select Show Call Tree Before: displays Call Tree but not expanded to selected time After: displays Call Tree expanded to selected time

Adrian Hunter committed 6 years ago

Commit f18d5cf1 parent 031c8d51 file · +4 −0Browse files

Showing the changes to tools/perf/scripts/python (1 of 1 file). Show all

Unified · Split

tools/perf/scripts/python/exported-sql-viewer.py+4−0
@@ -1130,6 +1130,7 @@ class CallTreeWindow(TreeWindowBase): · 1129 unmodified lines
1130 child = self.model.index(row, 0, parent)1130 child = self.model.index(row, 0, parent)
1131 if child.internalPointer().dbid == dbid:1131 if child.internalPointer().dbid == dbid:
1132 found = True1132 found = True
1133 self.view.setExpanded(parent, True)
1133 self.view.setCurrentIndex(child)1134 self.view.setCurrentIndex(child)
1134 parent = child1135 parent = child
1135 break1136 break
@@ -1142,6 +1143,7 @@ class CallTreeWindow(TreeWindowBase): · 6 unmodified lines
1142 return1143 return
1143 last_child = None1144 last_child = None
1144 for row in xrange(n):1145 for row in xrange(n):
1146 self.view.setExpanded(parent, True)
1145 child = self.model.index(row, 0, parent)1147 child = self.model.index(row, 0, parent)
1146 child_call_time = child.internalPointer().call_time1148 child_call_time = child.internalPointer().call_time
1147 if child_call_time < time:1149 if child_call_time < time:
@@ -1154,9 +1156,11 @@ class CallTreeWindow(TreeWindowBase): · 6 unmodified lines
1154 if not last_child:1156 if not last_child:
1155 if not found:1157 if not found:
1156 child = self.model.index(0, 0, parent)1158 child = self.model.index(0, 0, parent)
1159 self.view.setExpanded(parent, True)
1157 self.view.setCurrentIndex(child)1160 self.view.setCurrentIndex(child)
1158 return1161 return
1159 found = True1162 found = True
1163 self.view.setExpanded(parent, True)
1160 self.view.setCurrentIndex(last_child)1164 self.view.setCurrentIndex(last_child)
1161 parent = last_child1165 parent = last_child
1162 1166