History

thermal: core: Restore behavior regarding invalid trip points

Commit 7c3d5c20dc16 ("thermal/core: Add a generic thermal_zone_get_trip() function") stopped marking trip points with a zero temperature as disabled, behavior that was originally introduced in commit 81ad4276b505 ("Thermal: Ignore invalid trip points"). When using the mlxsw driver we see that when such trip points are not disabled, the thermal subsystem repeatedly tries to set the state of the associated cooling devices to the maximum state. Address this by restoring the original behavior and mark trip points with a zero temperature as disabled.

Ido Schimmel committed 3 years ago

Commit f1b80a31 parent e8d018d1 file · +1 −1Browse files

Unified · Split

drivers/thermal/thermal_core.c+1−1
@@ -1309,7 +1309,7 @@ thermal_zone_device_register_with_trips(const char *type, struct thermal_trip *t · 1308 unmodified lines
1309 struct thermal_trip trip;1309 struct thermal_trip trip;
1310 1310
1311 result = thermal_zone_get_trip(tz, count, &trip);1311 result = thermal_zone_get_trip(tz, count, &trip);
1312 if (result)1312 if (result || !trip.temperature)
1313 set_bit(count, &tz->trips_disabled);1313 set_bit(count, &tz->trips_disabled);
1314 }1314 }
1315 1315