__sa1111_remove always frees its argument, so the subsequent reference to sachip->saved_state represents a use after free. __sa1111_remove does not appear to use the saved_state field, so the patch simply frees it first. A simplified version of the semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression E,E2; @@ __sa1111_remove(E) ... ( E = E2 | * E ) // </smpl>
Unified · Split
| @@ -1028,13 +1028,12 @@ static int sa1111_remove(struct platform_device *pdev) · 1027 unmodified lines | |||
| 1028 | struct sa1111 *sachip = platform_get_drvdata(pdev); | 1028 | struct sa1111 *sachip = platform_get_drvdata(pdev); |
| 1029 | 1029 | ||
| 1030 | if (sachip) { | 1030 | if (sachip) { |
| 1031 | __sa1111_remove(sachip); | ||
| 1032 | platform_set_drvdata(pdev, NULL); | ||
| 1033 | |||
| 1034 | #ifdef CONFIG_PM | 1031 | #ifdef CONFIG_PM |
| 1035 | kfree(sachip->saved_state); | 1032 | kfree(sachip->saved_state); |
| 1036 | sachip->saved_state = NULL; | 1033 | sachip->saved_state = NULL; |
| 1037 | #endif | 1034 | #endif |
| 1035 | __sa1111_remove(sachip); | ||
| 1036 | platform_set_drvdata(pdev, NULL); | ||
| 1038 | } | 1037 | } |
| 1039 | 1038 | ||
| 1040 | return 0; | 1039 | return 0; |