History

livepatch: Use static buffer for debugging messages under rq lock

The err_buf array uses 128 bytes of stack space. Move it off the stack by making it static. It's safe to use a shared buffer because klp_try_switch_task() is called under klp_mutex.

Petr Mladek committed 7 years ago

Commit f36e6641 parent 573de2a1 file · +1 −2Browse files

Showing the changes to kernel/livepatch (1 of 1 file). Show all

Unified · Split

kernel/livepatch/transition.c+1−2
@@ -293,11 +293,11 @@ static int klp_check_stack(struct task_struct *task, char *err_buf) · 292 unmodified lines
293293 */
294294 static bool klp_try_switch_task(struct task_struct *task)
295295 {
296+ static char err_buf[STACK_ERR_BUF_SIZE];
296297 struct rq *rq;
297298 struct rq_flags flags;
298299 int ret;
299300 bool success = false;
300− char err_buf[STACK_ERR_BUF_SIZE];
301301
302302 err_buf[0] = '\0';
303303
@@ -340,7 +340,6 @@ done: · 36 unmodified lines
340340 pr_debug("%s", err_buf);
341341
342342 return success;
343−
344343 }
345344
346345 /*

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t