History

kallsyms: add static qualifiers where missing

Fix the following sparse warnings: scripts/kallsyms.c:65:5: warning: symbol 'token_profit' was not declared. Should it be static? scripts/kallsyms.c:68:15: warning: symbol 'best_table' was not declared. Should it be static? scripts/kallsyms.c:69:15: warning: symbol 'best_table_len' was not declared. Should it be static? Also, remove 'inline' from is_arm_mapping_symbol(). The compiler will inline it anyway when it is appropriate to do so.

Masahiro Yamada committed 7 years ago

Commit f43e9da1 parent 3a51ff31 file · +4 −4Browse files

Unified · Split

scripts/kallsyms.c+4−4
@@ -62,11 +62,11 @@ static int all_symbols = 0; · 61 unmodified lines
6262 static int absolute_percpu = 0;
6363 static int base_relative = 0;
6464
65−int token_profit[0x10000];
65+static int token_profit[0x10000];
6666
6767 /* the table that holds the result of the compression */
68−unsigned char best_table[256][2];
69−unsigned char best_table_len[256];
68+static unsigned char best_table[256][2];
69+static unsigned char best_table_len[256];
7070
7171
7272 static void usage(void)
@@ -80,7 +80,7 @@ static void usage(void) · 7 unmodified lines
8080 * This ignores the intensely annoying "mapping symbols" found
8181 * in ARM ELF files: $a, $t and $d.
8282 */
83−static inline int is_arm_mapping_symbol(const char *str)
83+static int is_arm_mapping_symbol(const char *str)
8484 {
8585 return str[0] == '$' && strchr("axtd", str[1])
8686 && (str[2] == '\0' || str[2] == '.');