History

rust: compile libcore with edition 2024 for 1.87+

Rust 1.87 (released on 2025-05-15) compiles core library with edition 2024 instead of 2021 [1]. Ensure that the edition matches libcore's expectation to avoid potential breakage. [ J3m3 reported in Zulip [2] that the `rust-analyzer` target was broken after this patch -- indeed, we need to avoid `core-cfgs` since those are passed to the `rust-analyzer` target. So, instead, I tweaked the patch to create a new `core-edition` variable and explicitly mention the `--edition` flag instead of reusing `core-cfg`s. In addition, pass a new argument using this new variable to `generate_rust_analyzer.py` so that we set the right edition there. By the way, for future reference: the `filter-out` change is needed for Rust < 1.87, since otherwise we would skip the `--edition=2021` we just added, ending up with no edition flag, and thus the compiler would default to the 2015 one. [2] https://rust-for-linux.zulipchat.com/#narrow/channel/291565/topic/x/near/520206547 - Miguel ]

Gary Guo committed 1 year ago

Commit f4daa801 parent df523db2 files · +16 −11Browse files

Unified · Split

2 files
  1. rust/Makefile +8 −6
  2. scripts/generate_rust_analyzer.py +8 −5
rust/Makefile+8−6
@@ -60,6 +60,8 @@ endif · 59 unmodified lines
6060 core-cfgs = \
6161 --cfg no_fp_fmt_parse
6262
63+core-edition := $(if $(call rustc-min-version,108700),2024,2021)
64+
6365 # `rustc` recognizes `--remap-path-prefix` since 1.26.0, but `rustdoc` only
6466 # since Rust 1.81.0. Moreover, `rustdoc` ICEs on out-of-tree builds since Rust
6567 # 1.82.0 (https://github.com/rust-lang/rust/issues/138520). Thus workaround both
@@ -106,8 +108,8 @@ rustdoc-macros: $(src)/macros/lib.rs FORCE · 40 unmodified lines
106108
107109 # Starting with Rust 1.82.0, skipping `-Wrustdoc::unescaped_backticks` should
108110 # not be needed -- see https://github.com/rust-lang/rust/pull/128307.
109−rustdoc-core: private skip_flags = -Wrustdoc::unescaped_backticks
110−rustdoc-core: private rustc_target_flags = $(core-cfgs)
111+rustdoc-core: private skip_flags = --edition=2021 -Wrustdoc::unescaped_backticks
112+rustdoc-core: private rustc_target_flags = --edition=$(core-edition) $(core-cfgs)
111113 rustdoc-core: $(RUST_LIB_SRC)/core/src/lib.rs FORCE
112114 +$(call if_changed,rustdoc)
113115
@@ -416,7 +418,7 @@ quiet_cmd_rustc_library = $(if $(skip_clippy),RUSTC,$(RUSTC_OR_CLIPPY_QUIET)) L · 302 unmodified lines
416418 cmd_rustc_library = \
417419 OBJTREE=$(abspath $(objtree)) \
418420 $(if $(skip_clippy),$(RUSTC),$(RUSTC_OR_CLIPPY)) \
419− $(filter-out $(skip_flags),$(rust_flags) $(rustc_target_flags)) \
421+ $(filter-out $(skip_flags),$(rust_flags)) $(rustc_target_flags) \
420422 --emit=dep-info=$(depfile) --emit=obj=$@ \
421423 --emit=metadata=$(dir $@)$(patsubst %.o,lib%.rmeta,$(notdir $@)) \
422424 --crate-type rlib -L$(objtree)/$(obj) \
@@ -427,7 +429,7 @@ quiet_cmd_rustc_library = $(if $(skip_clippy),RUSTC,$(RUSTC_OR_CLIPPY_QUIET)) L · 4 unmodified lines
427429
428430 rust-analyzer:
429431 $(Q)MAKEFLAGS= $(srctree)/scripts/generate_rust_analyzer.py \
430− --cfgs='core=$(core-cfgs)' \
432+ --cfgs='core=$(core-cfgs)' $(core-edition) \
431433 $(realpath $(srctree)) $(realpath $(objtree)) \
432434 $(rustc_sysroot) $(RUST_LIB_SRC) $(if $(KBUILD_EXTMOD),$(srcroot)) \
433435 > rust-project.json
@@ -483,9 +485,9 @@ $(obj)/helpers/helpers.o: $(src)/helpers/helpers.c $(recordmcount_source) FORCE · 49 unmodified lines
483485 $(obj)/exports.o: private skip_gendwarfksyms = 1
484486
485487 $(obj)/core.o: private skip_clippy = 1
486−$(obj)/core.o: private skip_flags = -Wunreachable_pub
488+$(obj)/core.o: private skip_flags = --edition=2021 -Wunreachable_pub
487489 $(obj)/core.o: private rustc_objcopy = $(foreach sym,$(redirect-intrinsics),--redefine-sym $(sym)=__rust$(sym))
488−$(obj)/core.o: private rustc_target_flags = $(core-cfgs)
490+$(obj)/core.o: private rustc_target_flags = --edition=$(core-edition) $(core-cfgs)
489491 $(obj)/core.o: $(RUST_LIB_SRC)/core/src/lib.rs \
490492 $(wildcard $(objtree)/include/config/RUSTC_VERSION_TEXT) FORCE
491493 +$(call if_changed_rule,rustc_library)
scripts/generate_rust_analyzer.py+8−5
@@ -19,7 +19,7 @@ def args_crates_cfgs(cfgs): · 18 unmodified lines
1919
2020 return crates_cfgs
2121
22−def generate_crates(srctree, objtree, sysroot_src, external_src, cfgs):
22+def generate_crates(srctree, objtree, sysroot_src, external_src, cfgs, core_edition):
2323 # Generate the configuration list.
2424 cfg = []
2525 with open(objtree / "include" / "generated" / "rustc_cfg") as fd:
@@ -35,7 +35,7 @@ def generate_crates(srctree, objtree, sysroot_src, external_src, cfgs): · 9 unmodified lines
3535 crates_indexes = {}
3636 crates_cfgs = args_crates_cfgs(cfgs)
3737
38− def append_crate(display_name, root_module, deps, cfg=[], is_workspace_member=True, is_proc_macro=False):
38+ def append_crate(display_name, root_module, deps, cfg=[], is_workspace_member=True, is_proc_macro=False, edition="2021"):
3939 crate = {
4040 "display_name": display_name,
4141 "root_module": str(root_module),
@@ -43,7 +43,7 @@ def generate_crates(srctree, objtree, sysroot_src, external_src, cfgs): · 1 unmodified line
4343 "is_proc_macro": is_proc_macro,
4444 "deps": [{"crate": crates_indexes[dep], "name": dep} for dep in deps],
4545 "cfg": cfg,
46− "edition": "2021",
46+ "edition": edition,
4747 "env": {
4848 "RUST_MODFILE": "This is only for rust-analyzer"
4949 }
@@ -61,6 +61,7 @@ def generate_crates(srctree, objtree, sysroot_src, external_src, cfgs): · 11 unmodified lines
6161 display_name,
6262 deps,
6363 cfg=[],
64+ edition="2021",
6465 ):
6566 append_crate(
6667 display_name,
@@ -68,12 +69,13 @@ def generate_crates(srctree, objtree, sysroot_src, external_src, cfgs): · 1 unmodified line
6869 deps,
6970 cfg,
7071 is_workspace_member=False,
72+ edition=edition,
7173 )
7274
7375 # NB: sysroot crates reexport items from one another so setting up our transitive dependencies
7476 # here is important for ensuring that rust-analyzer can resolve symbols. The sources of truth
7577 # for this dependency graph are `(sysroot_src / crate / "Cargo.toml" for crate in crates)`.
76− append_sysroot_crate("core", [], cfg=crates_cfgs.get("core", []))
78+ append_sysroot_crate("core", [], cfg=crates_cfgs.get("core", []), edition=core_edition)
7779 append_sysroot_crate("alloc", ["core"])
7880 append_sysroot_crate("std", ["alloc", "core"])
7981 append_sysroot_crate("proc_macro", ["core", "std"])
@@ -177,6 +179,7 @@ def main(): · 97 unmodified lines
177179 parser = argparse.ArgumentParser()
178180 parser.add_argument('--verbose', '-v', action='store_true')
179181 parser.add_argument('--cfgs', action='append', default=[])
182+ parser.add_argument("core_edition")
180183 parser.add_argument("srctree", type=pathlib.Path)
181184 parser.add_argument("objtree", type=pathlib.Path)
182185 parser.add_argument("sysroot", type=pathlib.Path)
@@ -193,7 +196,7 @@ def main(): · 10 unmodified lines
193196 assert args.sysroot in args.sysroot_src.parents
194197
195198 rust_project = {
196− "crates": generate_crates(args.srctree, args.objtree, args.sysroot_src, args.exttree, args.cfgs),
199+ "crates": generate_crates(args.srctree, args.objtree, args.sysroot_src, args.exttree, args.cfgs, args.core_edition),
197200 "sysroot": str(args.sysroot),
198201 }
199202

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t