History

PCI: Fix typos and whitespace errors

Fix typos in drivers/pci. Comment and whitespace changes only.

Bjorn Helgaas committed 7 years ago

Commit f6b6aef1 parent a18833916 files · +41 −40Browse files

Unified · Split

16 files
  1. drivers/pci/ats.c +1 −1
  2. drivers/pci/controller/dwc/pcie-armada8k.c +1 −1
  3. drivers/pci/controller/dwc/pcie-kirin.c +1 −1
  4. drivers/pci/controller/pci-aardvark.c +1 −1
  5. drivers/pci/controller/pcie-iproc-platform.c +1 −1
  6. drivers/pci/controller/pcie-iproc.c +1 −1
  7. drivers/pci/controller/vmd.c +1 −1
  8. drivers/pci/mmap.c +1 −1
  9. drivers/pci/msi.c +22 −21
  10. drivers/pci/p2pdma.c +3 −3
  11. drivers/pci/pci-bridge-emul.c +1 −1
  12. drivers/pci/pci-pf-stub.c +1 −1
  13. drivers/pci/pci.c +1 −1
  14. drivers/pci/pcie/aer_inject.c +1 −1
  15. include/linux/pci.h +1 −1
  16. include/linux/pci_ids.h +3 −3
drivers/pci/ats.c+1−1
@@ -432,7 +432,7 @@ EXPORT_SYMBOL_GPL(pci_prg_resp_pasid_required); · 431 unmodified lines
432432 * @pdev: PCI device structure
433433 *
434434 * Returns negative value when PASID capability is not present.
435− * Otherwise it returns the numer of supported PASIDs.
435+ * Otherwise it returns the number of supported PASIDs.
436436 */
437437 int pci_max_pasids(struct pci_dev *pdev)
438438 {
drivers/pci/controller/dwc/pcie-armada8k.c+1−1
@@ -55,7 +55,7 @@ struct armada8k_pcie { · 54 unmodified lines
5555 #define PCIE_ARUSER_REG (PCIE_VENDOR_REGS_OFFSET + 0x5C)
5656 #define PCIE_AWUSER_REG (PCIE_VENDOR_REGS_OFFSET + 0x60)
5757 /*
58− * AR/AW Cache defauls: Normal memory, Write-Back, Read / Write
58+ * AR/AW Cache defaults: Normal memory, Write-Back, Read / Write
5959 * allocate
6060 */
6161 #define ARCACHE_DEFAULT_VALUE 0x3511
drivers/pci/controller/dwc/pcie-kirin.c+1−1
@@ -2,7 +2,7 @@ · 1 unmodified line
22 /*
33 * PCIe host controller driver for Kirin Phone SoCs
44 *
5− * Copyright (C) 2017 Hilisicon Electronics Co., Ltd.
5+ * Copyright (C) 2017 HiSilicon Electronics Co., Ltd.
66 * http://www.huawei.com
77 *
88 * Author: Xiaowei Song <songxiaowei@huawei.com>
drivers/pci/controller/pci-aardvark.c+1−1
@@ -308,7 +308,7 @@ static void advk_pcie_setup_hw(struct advk_pcie *pcie) · 307 unmodified lines
308308
309309 advk_writel(pcie, PCIE_ISR1_ALL_MASK, PCIE_ISR1_MASK_REG);
310310
311− /* Unmask all MSI's */
311+ /* Unmask all MSIs */
312312 advk_writel(pcie, 0, PCIE_MSI_MASK_REG);
313313
314314 /* Enable summary interrupt for GIC SPI source */
drivers/pci/controller/pcie-iproc-platform.c+1−1
@@ -87,7 +87,7 @@ static int iproc_pcie_pltfm_probe(struct platform_device *pdev) · 86 unmodified lines
8787
8888 /*
8989 * DT nodes are not used by all platforms that use the iProc PCIe
90− * core driver. For platforms that require explict inbound mapping
90+ * core driver. For platforms that require explicit inbound mapping
9191 * configuration, "dma-ranges" would have been present in DT
9292 */
9393 pcie->need_ib_cfg = of_property_read_bool(np, "dma-ranges");
drivers/pci/controller/pcie-iproc.c+1−1
@@ -163,7 +163,7 @@ enum iproc_pcie_ib_map_type { · 162 unmodified lines
163163 * @size_unit: inbound mapping region size unit, could be SZ_1K, SZ_1M, or
164164 * SZ_1G
165165 * @region_sizes: list of supported inbound mapping region sizes in KB, MB, or
166− * GB, depedning on the size unit
166+ * GB, depending on the size unit
167167 * @nr_sizes: number of supported inbound mapping region sizes
168168 * @nr_windows: number of supported inbound mapping windows for the region
169169 * @imap_addr_offset: register offset between the upper and lower 32-bit
drivers/pci/controller/vmd.c+1−1
@@ -627,7 +627,7 @@ static int vmd_enable_domain(struct vmd_dev *vmd, unsigned long features) · 626 unmodified lines
627627 * 32-bit resources. __pci_assign_resource() enforces that
628628 * artificial restriction to make sure everything will fit.
629629 *
630− * The only way we could use a 64-bit non-prefechable MEMBAR is
630+ * The only way we could use a 64-bit non-prefetchable MEMBAR is
631631 * if its address is <4GB so that we can convert it to a 32-bit
632632 * resource. To be visible to the host OS, all VMD endpoints must
633633 * be initially configured by platform BIOS, which includes setting
drivers/pci/mmap.c+1−1
@@ -73,7 +73,7 @@ int pci_mmap_resource_range(struct pci_dev *pdev, int bar, · 72 unmodified lines
7373 #elif defined(HAVE_PCI_MMAP) /* && !ARCH_GENERIC_PCI_MMAP_RESOURCE */
7474
7575 /*
76− * Legacy setup: Impement pci_mmap_resource_range() as a wrapper around
76+ * Legacy setup: Implement pci_mmap_resource_range() as a wrapper around
7777 * the architecture's pci_mmap_page_range(), converting to "user visible"
7878 * addresses as necessary.
7979 */
drivers/pci/msi.c+22−21
@@ -237,7 +237,7 @@ static void msi_set_mask_bit(struct irq_data *data, u32 flag) · 236 unmodified lines
237237 }
238238
239239 /**
240− * pci_msi_mask_irq - Generic irq chip callback to mask PCI/MSI interrupts
240+ * pci_msi_mask_irq - Generic IRQ chip callback to mask PCI/MSI interrupts
241241 * @data: pointer to irqdata associated to that interrupt
242242 */
243243 void pci_msi_mask_irq(struct irq_data *data)
@@ -247,7 +247,7 @@ void pci_msi_mask_irq(struct irq_data *data) · 3 unmodified lines
247247 EXPORT_SYMBOL_GPL(pci_msi_mask_irq);
248248
249249 /**
250− * pci_msi_unmask_irq - Generic irq chip callback to unmask PCI/MSI interrupts
250+ * pci_msi_unmask_irq - Generic IRQ chip callback to unmask PCI/MSI interrupts
251251 * @data: pointer to irqdata associated to that interrupt
252252 */
253253 void pci_msi_unmask_irq(struct irq_data *data)
@@ -588,11 +588,11 @@ static int msi_verify_entries(struct pci_dev *dev) · 334 unmodified lines
588588 * msi_capability_init - configure device's MSI capability structure
589589 * @dev: pointer to the pci_dev data structure of MSI device function
590590 * @nvec: number of interrupts to allocate
591− * @affd: description of automatic irq affinity assignments (may be %NULL)
591+ * @affd: description of automatic IRQ affinity assignments (may be %NULL)
592592 *
593593 * Setup the MSI capability structure of the device with the requested
594594 * number of interrupts. A return value of zero indicates the successful
595− * setup of an entry with the new MSI irq. A negative return value indicates
595+ * setup of an entry with the new MSI IRQ. A negative return value indicates
596596 * an error, and a positive return value indicates the number of interrupts
597597 * which could have been allocated.
598598 */
@@ -609,7 +609,7 @@ static int msi_capability_init(struct pci_dev *dev, int nvec, · 10 unmodified lines
609609 if (!entry)
610610 return -ENOMEM;
611611
612− /* All MSIs are unmasked by default, Mask them all */
612+ /* All MSIs are unmasked by default; mask them all */
613613 mask = msi_mask(entry->msi_attrib.multi_cap);
614614 msi_mask_irq(entry, mask, mask);
615615
@@ -637,7 +637,7 @@ static int msi_capability_init(struct pci_dev *dev, int nvec, · 21 unmodified lines
637637 return ret;
638638 }
639639
640− /* Set MSI enabled bits */
640+ /* Set MSI enabled bits */
641641 pci_intx_for_msi(dev, 0);
642642 pci_msi_set_enable(dev, 1);
643643 dev->msi_enabled = 1;
@@ -729,11 +729,11 @@ static void msix_program_entries(struct pci_dev *dev, · 85 unmodified lines
729729 * @dev: pointer to the pci_dev data structure of MSI-X device function
730730 * @entries: pointer to an array of struct msix_entry entries
731731 * @nvec: number of @entries
732− * @affd: Optional pointer to enable automatic affinity assignement
732+ * @affd: Optional pointer to enable automatic affinity assignment
733733 *
734734 * Setup the MSI-X capability structure of device function with a
735− * single MSI-X irq. A return of zero indicates the successful setup of
736− * requested MSI-X entries with allocated irqs or non-zero for otherwise.
735+ * single MSI-X IRQ. A return of zero indicates the successful setup of
736+ * requested MSI-X entries with allocated IRQs or non-zero for otherwise.
737737 **/
738738 static int msix_capability_init(struct pci_dev *dev, struct msix_entry *entries,
739739 int nvec, struct irq_affinity *affd)
@@ -789,7 +789,7 @@ static int msix_capability_init(struct pci_dev *dev, struct msix_entry *entries, · 49 unmodified lines
789789 out_avail:
790790 if (ret < 0) {
791791 /*
792− * If we had some success, report the number of irqs
792+ * If we had some success, report the number of IRQs
793793 * we succeeded in setting up.
794794 */
795795 struct msi_desc *entry;
@@ -812,7 +812,7 @@ out_free: · 16 unmodified lines
812812 /**
813813 * pci_msi_supported - check whether MSI may be enabled on a device
814814 * @dev: pointer to the pci_dev data structure of MSI device function
815− * @nvec: how many MSIs have been requested ?
815+ * @nvec: how many MSIs have been requested?
816816 *
817817 * Look at global flags, the device itself, and its parent buses
818818 * to determine if MSI/-X are supported for the device. If MSI/-X is
@@ -896,7 +896,7 @@ static void pci_msi_shutdown(struct pci_dev *dev) · 77 unmodified lines
896896 /* Keep cached state to be restored */
897897 __pci_msi_desc_mask_irq(desc, mask, ~mask);
898898
899− /* Restore dev->irq to its default pin-assertion irq */
899+ /* Restore dev->irq to its default pin-assertion IRQ */
900900 dev->irq = desc->msi_attrib.default_irq;
901901 pcibios_alloc_irq(dev);
902902 }
@@ -958,7 +958,7 @@ static int __pci_enable_msix(struct pci_dev *dev, struct msix_entry *entries, · 55 unmodified lines
958958 }
959959 }
960960
961− /* Check whether driver already requested for MSI irq */
961+ /* Check whether driver already requested for MSI IRQ */
962962 if (dev->msi_enabled) {
963963 pci_info(dev, "can't enable MSI-X (MSI IRQ already assigned)\n");
964964 return -EINVAL;
@@ -1026,7 +1026,7 @@ static int __pci_enable_msi_range(struct pci_dev *dev, int minvec, int maxvec, · 61 unmodified lines
10261026 if (!pci_msi_supported(dev, minvec))
10271027 return -EINVAL;
10281028
1029− /* Check whether driver already requested MSI-X irqs */
1029+ /* Check whether driver already requested MSI-X IRQs */
10301030 if (dev->msix_enabled) {
10311031 pci_info(dev, "can't enable MSI (MSI-X already enabled)\n");
10321032 return -EINVAL;
@@ -1113,8 +1113,8 @@ static int __pci_enable_msix_range(struct pci_dev *dev, · 80 unmodified lines
11131113 * pci_enable_msix_range - configure device's MSI-X capability structure
11141114 * @dev: pointer to the pci_dev data structure of MSI-X device function
11151115 * @entries: pointer to an array of MSI-X entries
1116− * @minvec: minimum number of MSI-X irqs requested
1117− * @maxvec: maximum number of MSI-X irqs requested
1116+ * @minvec: minimum number of MSI-X IRQs requested
1117+ * @maxvec: maximum number of MSI-X IRQs requested
11181118 *
11191119 * Setup the MSI-X capability structure of device function with a maximum
11201120 * possible number of interrupts in the range between @minvec and @maxvec
@@ -1179,7 +1179,7 @@ int pci_alloc_irq_vectors_affinity(struct pci_dev *dev, unsigned int min_vecs, · 58 unmodified lines
11791179 return msi_vecs;
11801180 }
11811181
1182− /* use legacy irq if allowed */
1182+ /* use legacy IRQ if allowed */
11831183 if (flags & PCI_IRQ_LEGACY) {
11841184 if (min_vecs == 1 && dev->irq) {
11851185 /*
@@ -1248,7 +1248,7 @@ int pci_irq_vector(struct pci_dev *dev, unsigned int nr) · 62 unmodified lines
12481248 EXPORT_SYMBOL(pci_irq_vector);
12491249
12501250 /**
1251− * pci_irq_get_affinity - return the affinity of a particular msi vector
1251+ * pci_irq_get_affinity - return the affinity of a particular MSI vector
12521252 * @dev: PCI device to operate on
12531253 * @nr: device-relative interrupt vector index (0-based).
12541254 */
@@ -1280,7 +1280,7 @@ const struct cpumask *pci_irq_get_affinity(struct pci_dev *dev, int nr) · 25 unmodified lines
12801280 EXPORT_SYMBOL(pci_irq_get_affinity);
12811281
12821282 /**
1283− * pci_irq_get_node - return the numa node of a particular msi vector
1283+ * pci_irq_get_node - return the NUMA node of a particular MSI vector
12841284 * @pdev: PCI device to operate on
12851285 * @vec: device-relative interrupt vector index (0-based).
12861286 */
@@ -1330,7 +1330,7 @@ void pci_msi_domain_write_msg(struct irq_data *irq_data, struct msi_msg *msg) · 43 unmodified lines
13301330 /**
13311331 * pci_msi_domain_calc_hwirq - Generate a unique ID for an MSI source
13321332 * @dev: Pointer to the PCI device
1333− * @desc: Pointer to the msi descriptor
1333+ * @desc: Pointer to the MSI descriptor
13341334 *
13351335 * The ID number is only used within the irqdomain.
13361336 */
@@ -1348,7 +1348,8 @@ static inline bool pci_msi_desc_is_multi_msi(struct msi_desc *desc) · 11 unmodified lines
13481348 }
13491349
13501350 /**
1351− * pci_msi_domain_check_cap - Verify that @domain supports the capabilities for @dev
1351+ * pci_msi_domain_check_cap - Verify that @domain supports the capabilities
1352+ * for @dev
13521353 * @domain: The interrupt domain to check
13531354 * @info: The domain info for verification
13541355 * @dev: The device to check
drivers/pci/p2pdma.c+3−3
@@ -223,7 +223,7 @@ EXPORT_SYMBOL_GPL(pci_p2pdma_add_resource); · 222 unmodified lines
223223
224224 /*
225225 * Note this function returns the parent PCI device with a
226− * reference taken. It is the caller's responsibily to drop
226+ * reference taken. It is the caller's responsibility to drop
227227 * the reference.
228228 */
229229 static struct pci_dev *find_parent_pci_dev(struct device *dev)
@@ -380,7 +380,7 @@ static int upstream_bridge_distance(struct pci_dev *provider, · 150 unmodified lines
380380
381381 /*
382382 * Allow the connection if both devices are on a whitelisted root
383− * complex, but add an arbitary large value to the distance.
383+ * complex, but add an arbitrary large value to the distance.
384384 */
385385 if (root_complex_whitelist(provider) &&
386386 root_complex_whitelist(client))
@@ -439,7 +439,7 @@ static int upstream_bridge_distance_warn(struct pci_dev *provider, · 52 unmodified lines
439439 }
440440
441441 /**
442− * pci_p2pdma_distance_many - Determive the cumulative distance between
442+ * pci_p2pdma_distance_many - Determine the cumulative distance between
443443 * a p2pdma provider and the clients in use.
444444 * @provider: p2pdma provider to check against the client list
445445 * @clients: array of devices to check (NULL-terminated)
drivers/pci/pci-bridge-emul.c+1−1
@@ -305,7 +305,7 @@ int pci_bridge_emul_init(struct pci_bridge_emul *bridge, · 304 unmodified lines
305305 }
306306
307307 /*
308− * Cleanup a pci_bridge_emul structure that was previously initilized
308+ * Cleanup a pci_bridge_emul structure that was previously initialized
309309 * using pci_bridge_emul_init().
310310 */
311311 void pci_bridge_emul_cleanup(struct pci_bridge_emul *bridge)
drivers/pci/pci-pf-stub.c+1−1
@@ -1,7 +1,7 @@
11 // SPDX-License-Identifier: GPL-2.0
22 /* pci-pf-stub - simple stub driver for PCI SR-IOV PF device
33 *
4− * This driver is meant to act as a "whitelist" for devices that provde
4+ * This driver is meant to act as a "whitelist" for devices that provide
55 * SR-IOV functionality while at the same time not actually needing a
66 * driver of their own.
77 */
drivers/pci/pci.c+1−1
@@ -4501,7 +4501,7 @@ static int pci_af_flr(struct pci_dev *dev, int probe) · 4500 unmodified lines
45014501
45024502 /*
45034503 * Wait for Transaction Pending bit to clear. A word-aligned test
4504− * is used, so we use the conrol offset rather than status and shift
4504+ * is used, so we use the control offset rather than status and shift
45054505 * the test bit to match.
45064506 */
45074507 if (!pci_wait_for_pending(dev, pos + PCI_AF_CTRL,
drivers/pci/pcie/aer_inject.c+1−1
@@ -2,7 +2,7 @@ · 1 unmodified line
22 /*
33 * PCIe AER software error injection support.
44 *
5− * Debuging PCIe AER code is quite difficult because it is hard to
5+ * Debugging PCIe AER code is quite difficult because it is hard to
66 * trigger various real hardware errors. Software based error
77 * injection can fake almost all kinds of errors with the help of a
88 * user space helper tool aer-inject, which can be gotten from:
include/linux/pci.h+1−1
@@ -382,7 +382,7 @@ struct pci_dev { · 381 unmodified lines
382382
383383 unsigned int is_busmaster:1; /* Is busmaster */
384384 unsigned int no_msi:1; /* May not use MSI */
385− unsigned int no_64bit_msi:1; /* May only use 32-bit MSIs */
385+ unsigned int no_64bit_msi:1; /* May only use 32-bit MSIs */
386386 unsigned int block_cfg_access:1; /* Config space access blocked */
387387 unsigned int broken_parity_status:1; /* Generates false positive parity */
388388 unsigned int irq_reroute_variant:2; /* Needs IRQ rerouting variant */
include/linux/pci_ids.h+3−3
@@ -1112,7 +1112,7 @@ · 1111 unmodified lines
11121112
11131113 #define PCI_VENDOR_ID_AL 0x10b9
11141114 #define PCI_DEVICE_ID_AL_M1533 0x1533
1115−#define PCI_DEVICE_ID_AL_M1535 0x1535
1115+#define PCI_DEVICE_ID_AL_M1535 0x1535
11161116 #define PCI_DEVICE_ID_AL_M1541 0x1541
11171117 #define PCI_DEVICE_ID_AL_M1563 0x1563
11181118 #define PCI_DEVICE_ID_AL_M1621 0x1621
@@ -1752,7 +1752,7 @@ · 633 unmodified lines
17521752 #define PCI_VENDOR_ID_STALLION 0x124d
17531753
17541754 /* Allied Telesyn */
1755−#define PCI_VENDOR_ID_AT 0x1259
1755+#define PCI_VENDOR_ID_AT 0x1259
17561756 #define PCI_SUBDEVICE_ID_AT_2700FX 0x2701
17571757 #define PCI_SUBDEVICE_ID_AT_2701FX 0x2703
17581758
@@ -2550,7 +2550,7 @@ · 791 unmodified lines
25502550 #define PCI_DEVICE_ID_KORENIX_JETCARDF2 0x1700
25512551 #define PCI_DEVICE_ID_KORENIX_JETCARDF3 0x17ff
25522552
2553−#define PCI_VENDOR_ID_HUAWEI 0x19e5
2553+#define PCI_VENDOR_ID_HUAWEI 0x19e5
25542554
25552555 #define PCI_VENDOR_ID_NETRONOME 0x19ee
25562556 #define PCI_DEVICE_ID_NETRONOME_NFP4000 0x4000

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t