History

kconfig: gconf: fix potential memory leak in renderer_edited()

If gtk_tree_model_get_iter() fails, gtk_tree_path_free() is not called.

Masahiro Yamada committed 1 year ago

Commit f72ed4c1 parent 2f2d60f1 file · +2 −1Browse files

Unified · Split

scripts/kconfig/gconf.c+2−1
@@ -745,7 +745,7 @@ static void renderer_edited(GtkCellRendererText * cell, · 744 unmodified lines
745 struct symbol *sym;745 struct symbol *sym;
746 746
747 if (!gtk_tree_model_get_iter(model2, &iter, path))747 if (!gtk_tree_model_get_iter(model2, &iter, path))
748 return;748 goto free;
749 749
750 gtk_tree_model_get(model2, &iter, COL_MENU, &menu, -1);750 gtk_tree_model_get(model2, &iter, COL_MENU, &menu, -1);
751 sym = menu->sym;751 sym = menu->sym;
@@ -757,6 +757,7 @@ static void renderer_edited(GtkCellRendererText * cell, · 5 unmodified lines
757 757
758 update_tree(&rootmenu, NULL);758 update_tree(&rootmenu, NULL);
759 759
760free:
760 gtk_tree_path_free(path);761 gtk_tree_path_free(path);
761}762}
762 763