History

fork: report pid exhaustion correctly

Make the clone and fork syscalls return EAGAIN when the limit on the number of pids /proc/sys/kernel/pid_max is exceeded. Currently, when the pid_max limit is exceeded, the kernel will return ENOSPC from the fork and clone syscalls. This is contrary to the documented behaviour, which explicitly calls out the pid_max case as one where EAGAIN should be returned. It also leads to really confusing error messages in userspace programs which will complain about a lack of disk space when they fail to create processes/threads for this reason. This error is being returned because alloc_pid() uses the idr api to find a new pid; when there are none available, idr_alloc_cyclic() returns -ENOSPC, and this is being propagated back to userspace. This behaviour has been broken before, and was explicitly fixed in commit 35f71bc0a09a ("fork: report pid reservation failure properly"), so I think -EAGAIN is definitely the right thing to return in this case. The current behaviour change dates from commit 95846ecf9dac ("pid: replace pid bitmap implementation with IDR AIP") and was I believe unintentional. This patch has no impact on the case where allocating a pid fails because the child reaper for the namespace is dead; that case will still return -ENOMEM.

KJ Tsanaktsidis committed 8 years ago

Commit f83606f1 parent ae596de1 file · +1 −1Browse files

Unified · Split

kernel/pid.c+1−1
@@ -195,7 +195,7 @@ struct pid *alloc_pid(struct pid_namespace *ns) · 194 unmodified lines
195 idr_preload_end();195 idr_preload_end();
196 196
197 if (nr < 0) {197 if (nr < 0) {
198 retval = nr;198 retval = (nr == -ENOSPC) ? -EAGAIN : nr;
199 goto out_free;199 goto out_free;
200 }200 }
201 201

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t