History

blk-mq: introduce blk_mq_tagset_wait_completed_request()

blk-mq may schedule to call queue's complete function on remote CPU via IPI, but doesn't provide any way to synchronize the request's complete fn. The current queue freeze interface can't provide the synchonization because aborted requests stay at blk-mq queues during EH. In some driver's EH(such as NVMe), hardware queue's resource may be freed & re-allocated. If the completed request's complete fn is run finally after the hardware queue's resource is released, kernel crash will be triggered. Prepare for fixing this kind of issue by introducing blk_mq_tagset_wait_completed_request().

Ming Lei committed 7 years ago

Commit f9934a81 parent aa306ab2 files · +33 −0Browse files

Showing the changes to include/linux (1 of 2 files). Show all

Unified · Split

include/linux/blk-mq.h+1−0
@@ -322,6 +322,7 @@ bool blk_mq_run_hw_queue(struct blk_mq_hw_ctx *hctx, bool async); · 321 unmodified lines
322322 void blk_mq_run_hw_queues(struct request_queue *q, bool async);
323323 void blk_mq_tagset_busy_iter(struct blk_mq_tag_set *tagset,
324324 busy_tag_iter_fn *fn, void *priv);
325+void blk_mq_tagset_wait_completed_request(struct blk_mq_tag_set *tagset);
325326 void blk_mq_freeze_queue(struct request_queue *q);
326327 void blk_mq_unfreeze_queue(struct request_queue *q);
327328 void blk_freeze_queue_start(struct request_queue *q);

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t