History

x86: Mark stop_this_cpu() __noreturn

vmlinux.o: warning: objtool: smp_stop_nmi_callback()+0x2b: unreachable instruction 0000 0000000000047cf0 <smp_stop_nmi_callback>: ... 0026 47d16: e8 00 00 00 00 call 47d1b <smp_stop_nmi_callback+0x2b> 47d17: R_X86_64_PLT32 stop_this_cpu-0x4 002b 47d1b: b8 01 00 00 00 mov $0x1,%eax

Peter Zijlstra committed 4 years ago

Commit f9cdf7c1 parent 4adb2363 files · +3 −2Browse files

Unified · Split

3 files
  1. arch/x86/include/asm/processor.h +1 −1
  2. arch/x86/kernel/process.c +1 −1
  3. tools/objtool/check.c +1 −0
arch/x86/include/asm/processor.h+1−1
@@ -835,7 +835,7 @@ bool xen_set_default_idle(void); · 834 unmodified lines
835835 #define xen_set_default_idle 0
836836 #endif
837837
838−void stop_this_cpu(void *dummy);
838+void __noreturn stop_this_cpu(void *dummy);
839839 void microcode_check(void);
840840
841841 enum l1tf_mitigations {
arch/x86/kernel/process.c+1−1
@@ -747,7 +747,7 @@ bool xen_set_default_idle(void) · 746 unmodified lines
747747 }
748748 #endif
749749
750−void stop_this_cpu(void *dummy)
750+void __noreturn stop_this_cpu(void *dummy)
751751 {
752752 local_irq_disable();
753753 /*
tools/objtool/check.c+1−0
@@ -181,6 +181,7 @@ static bool __dead_end_function(struct objtool_file *file, struct symbol *func, · 180 unmodified lines
181181 "kunit_try_catch_throw",
182182 "xen_start_kernel",
183183 "cpu_bringup_and_idle",
184+ "stop_this_cpu",
184185 };
185186
186187 if (!func)

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t